From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752381AbcFFQnV (ORCPT ); Mon, 6 Jun 2016 12:43:21 -0400 Received: from smtprelay0239.hostedemail.com ([216.40.44.239]:38211 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750788AbcFFQnT (ORCPT ); Mon, 6 Jun 2016 12:43:19 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:7875:7904:10004:10400:10848:11026:11232:11658:11783:11914:12043:12517:12519:12555:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:21221:21433:30034:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: team77_39a49f6f7b31e X-Filterd-Recvd-Size: 2356 Message-ID: <1465231395.25087.13.camel@perches.com> Subject: Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test From: Joe Perches To: Yingjoe Chen , Andy Whitcroft , Andrew Morton Cc: linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, Andi Kleen , Paul Bolle Date: Mon, 06 Jun 2016 09:43:15 -0700 In-Reply-To: <1465017040-12777-1-git-send-email-yingjoe.chen@mediatek.com> References: <1465017040-12777-1-git-send-email-yingjoe.chen@mediatek.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote: > If a Kconfig config option doesn't specify 'default', the default > will be n. Adding 'default n' is unnecessary. > Add a test to warn about this. Is it obvious that a Kconfig has "default n" ? This seems to work, but is this useful? > Signed-off-by: Yingjoe Chen > --- > For this series, rebase to v4.7-rc1 and dropped 'relax Kconfig help text > line number threshold' patch. > > Let me know what you think. Thanks. > > > Change in v3: > - Rebase to v4.7-rc1 > > Change in v2: > - Change according to Joe Perches' suggesti > >  scripts/checkpatch.pl | 7 +++++++ >  1 file changed, 7 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 6750595..f5ce804 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2683,6 +2683,13 @@ sub process { >        "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); >   } >   > +# discourage the use of default n > + if ($realfile =~ /Kconfig/ && > +     $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) { > + WARN("CONFIG_DEFAULT_N", > +      "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); > + } > + >   if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && >       ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { >   my $flag = $1;