From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754612AbcFGIjW (ORCPT ); Tue, 7 Jun 2016 04:39:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56870 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754598AbcFGIjS convert rfc822-to-8bit (ORCPT ); Tue, 7 Jun 2016 04:39:18 -0400 Message-ID: <1465288755.14901.4.camel@redhat.com> Subject: Re: [PATCH RESEND 06/14] drm/virtio: use drm_crtc_send_vblank_event() From: Gerd Hoffmann To: Gustavo Padovan Cc: dri-devel@lists.freedesktop.org, Gustavo Padovan , David Airlie , "open list:VIRTIO GPU DRIVER" , open list Date: Tue, 07 Jun 2016 10:39:15 +0200 In-Reply-To: <1465224105-21485-6-git-send-email-gustavo@padovan.org> References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-6-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 07 Jun 2016 08:39:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mo, 2016-06-06 at 11:41 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_send_vblank_event() with the new helper function. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c > index d4305da..ba5e11b 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -156,7 +156,7 @@ static int virtio_gpu_page_flip(struct drm_crtc *crtc, > > if (event) { > spin_lock_irqsave(&crtc->dev->event_lock, irqflags); > - drm_send_vblank_event(crtc->dev, -1, event); > + drm_crtc_send_vblank_event(crtc, event); > spin_unlock_irqrestore(&crtc->dev->event_lock, irqflags); > } Daniel Vetter has a series in flight which drops the whole virtio_gpu_page_flip function in favor of drm_atomic_helper_page_flip. https://lists.freedesktop.org/archives/dri-devel/2016-May/108699.html cheers, Gerd