From: Joe Perches <joe@perches.com>
To: Jens Wiklander <jens.wiklander@linaro.org>, Nishanth Menon <nm@ti.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Andreas Dannenberg <dannenberg@ti.com>,
valentin.manea@huawei.com, jean-michel.delorme@st.com,
emmanuel.michel@st.com, javier@javigon.com,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Mark Rutland <mark.rutland@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v10 2/4] tee: generic TEE subsystem
Date: Tue, 07 Jun 2016 07:35:56 -0700 [thread overview]
Message-ID: <1465310156.25087.19.camel@perches.com> (raw)
In-Reply-To: <20160607105015.GA18132@ermac>
On Tue, 2016-06-07 at 12:50 +0200, Jens Wiklander wrote:
> On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote:
> >
> > On 06/01/2016 07:41 AM, Jens Wiklander wrote:
> > few minor comments below.
> >
> > I see the patch generated (with --strict):
> > >
> > > CHECK: Alignment should match open parenthesis
> > > #512: FILE: drivers/tee/tee.c:375:
> > > +static int tee_ioctl_close_session(struct tee_context *ctx,
> > > + struct tee_ioctl_close_session_arg __user *uarg)
> > > CHECK: Alignment should match open parenthesis
> > > #1607: FILE: drivers/tee/tee_shm_pool.c:103:
> > > +struct tee_shm_pool *tee_shm_pool_alloc_res_mem(struct device *dev,
> > > + struct tee_shm_pool_mem_info *priv_info,
> > > CHECK: Alignment should match open parenthesis
> The alternative is to format it as:
> struct tee_shm_pool *tee_shm_pool_alloc_res_mem(struct device *dev,
> struct tee_shm_pool_mem_info
> *priv_info,
> struct tee_shm_pool_mem_info
> *dmabuf_info)
> But that is a bit awkward. I'd like to keep it as it is if you don't mind.
another style uses a separate line for the return type
struct tee_shm_pool *
tee_shm_pool_alloc_res_mem(struct device *dev,
struct tee_shm_pool_mem_info *priv_info,
struct tee_shm_pool_mem_info *dmabuf_info)
next prev parent reply other threads:[~2016-06-07 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 12:41 [PATCH v10 0/4] generic TEE subsystem Jens Wiklander
2016-06-01 12:41 ` [PATCH v10 1/4] dt/bindings: add bindings for optee Jens Wiklander
2016-06-01 12:41 ` [PATCH v10 2/4] tee: generic TEE subsystem Jens Wiklander
2016-06-06 18:34 ` Javier González
2016-06-06 18:34 ` Javier González
2016-06-06 18:34 ` Javier González
2016-06-06 21:44 ` Nishanth Menon
2016-06-07 10:50 ` Jens Wiklander
2016-06-07 14:35 ` Joe Perches [this message]
2016-06-01 12:41 ` [PATCH v10 3/4] tee: add OP-TEE driver Jens Wiklander
2016-06-06 18:37 ` Javier González
2016-06-06 21:49 ` Nishanth Menon
2016-06-07 11:55 ` Jens Wiklander
2016-06-01 12:41 ` [PATCH v10 4/4] Documentation: tee subsystem and op-tee driver Jens Wiklander
2016-06-06 18:51 ` [PATCH v10 0/4] generic TEE subsystem Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465310156.25087.19.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=emmanuel.michel@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@javigon.com \
--cc=jean-michel.delorme@st.com \
--cc=jens.wiklander@linaro.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=valentin.manea@huawei.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox