From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755505AbcFGOgH (ORCPT ); Tue, 7 Jun 2016 10:36:07 -0400 Received: from smtprelay0185.hostedemail.com ([216.40.44.185]:58524 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754501AbcFGOgF (ORCPT ); Tue, 7 Jun 2016 10:36:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1978:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:3872:3873:3874:4321:5007:6742:10004:10400:10848:11026:11232:11658:11783:11889:11914:12043:12295:12296:12438:12517:12519:12740:13069:13311:13357:13439:13894:14659:14721:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: bath85_1739196d95c08 X-Filterd-Recvd-Size: 2949 Message-ID: <1465310156.25087.19.camel@perches.com> Subject: Re: [PATCH v10 2/4] tee: generic TEE subsystem From: Joe Perches To: Jens Wiklander , Nishanth Menon Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Greg Kroah-Hartman , Al Viro , Andreas Dannenberg , valentin.manea@huawei.com, jean-michel.delorme@st.com, emmanuel.michel@st.com, javier@javigon.com, Jason Gunthorpe , Mark Rutland , Michal Simek , Rob Herring , Will Deacon , Arnd Bergmann Date: Tue, 07 Jun 2016 07:35:56 -0700 In-Reply-To: <20160607105015.GA18132@ermac> References: <1464784888-19854-1-git-send-email-jens.wiklander@linaro.org> <1464784888-19854-3-git-send-email-jens.wiklander@linaro.org> <5755EECA.6040606@ti.com> <20160607105015.GA18132@ermac> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-06-07 at 12:50 +0200, Jens Wiklander wrote: > On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote: > > > > On 06/01/2016 07:41 AM, Jens Wiklander wrote: > > few minor comments below. > > > > I see the patch generated (with --strict): > > > > > > CHECK: Alignment should match open parenthesis > > > #512: FILE: drivers/tee/tee.c:375: > > > +static int tee_ioctl_close_session(struct tee_context *ctx, > > > +              struct tee_ioctl_close_session_arg __user *uarg) > > > CHECK: Alignment should match open parenthesis > > > #1607: FILE: drivers/tee/tee_shm_pool.c:103: > > > +struct tee_shm_pool *tee_shm_pool_alloc_res_mem(struct device *dev, > > > +                      struct tee_shm_pool_mem_info *priv_info, > > > CHECK: Alignment should match open parenthesis > The alternative is to format it as: > struct tee_shm_pool *tee_shm_pool_alloc_res_mem(struct device *dev, >                                                 struct tee_shm_pool_mem_info >                                                         *priv_info, >                                                 struct tee_shm_pool_mem_info >                                                         *dmabuf_info) > But that is a bit awkward. I'd like to keep it as it is if you don't mind. another style uses a separate line for the return type struct tee_shm_pool * tee_shm_pool_alloc_res_mem(struct device *dev,    struct tee_shm_pool_mem_info *priv_info,    struct tee_shm_pool_mem_info *dmabuf_info)