From: Joe Perches <joe@perches.com>
To: George Spelvin <linux@sciencehorizons.net>,
andriy.shevchenko@linux.intel.com
Cc: bjorn@mork.no, linux-kernel@vger.kernel.org,
matt@codeblueprint.co.uk, rv@rasmusvillemoes.dk
Subject: Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning
Date: Tue, 07 Jun 2016 10:13:58 -0700 [thread overview]
Message-ID: <1465319638.25087.29.camel@perches.com> (raw)
In-Reply-To: <20160607164302.27585.qmail@ns.sciencehorizons.net>
On Tue, 2016-06-07 at 12:43 -0400, George Spelvin wrote:
> Andy Shevchenko wrote:
> > To be sure it faster we need the measurements. Sometimes it's not
> > obvious.
[]
> Speaking pedantically, you're right. But as a practical matter, it's
> very unlikely, and what makes it truly insignificant is that it's not
> really a problem even if I'm wrong and the code *is* slower.
>
> As you said, size is more important than speed, and I did, at your
> request, benchmark that. I'm just trying to make the sort of changes
> that improve *both*.
>
> If you have a realistic concern that the patches degrade speed, I can
> put in a few hours of work to put the different versions into a test
> harness and measure it accurately.
>
> But if this is just a pro forma observation that estimates aren't
> perfectly reliable, it's not worth the effort.
Readability and correctness are probably more important than
runtime performance here.
prev parent reply other threads:[~2016-06-07 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1464952090.1767.34.camel@linux.intel.com>
2016-06-04 5:13 ` [PATCH v2 0/2] Clean up and shrink uuid input & output George Spelvin
2016-06-04 5:14 ` [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string() George Spelvin
2016-06-05 14:22 ` Andy Shevchenko
2016-06-05 19:57 ` George Spelvin
2016-06-04 5:14 ` [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays George Spelvin
2016-06-04 5:42 ` kbuild test robot
2016-06-04 16:29 ` Joe Perches
2016-06-04 21:57 ` George Spelvin
2016-06-05 14:19 ` Andy Shevchenko
2016-06-05 15:34 ` Joe Perches
2016-06-05 16:15 ` Andy Shevchenko
2016-06-04 13:16 ` [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning George Spelvin
2016-06-05 14:21 ` Andy Shevchenko
2016-06-05 19:25 ` George Spelvin
2016-06-06 8:24 ` Andy Shevchenko
2016-06-07 16:43 ` George Spelvin
2016-06-07 17:13 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465319638.25087.29.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sciencehorizons.net \
--cc=matt@codeblueprint.co.uk \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox