Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

Darren Hart
2016-06-09T21:55:29Z

On Thu, Jun 09, 2016 at 06:04:52PM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 09 Jun 2016, Darren Hart wrote:
> > On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > > 2016-06-08 10:54 GMT-04:00 Lyude <cpaul@redhat.com>:
> > > > From: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> > > >
> > > > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > > > HKEY version 0x200 without adaptive keyboard.
> > > >
> > > > HKEY version 0x200 has method MHKA with one parameter value.
> > > > Passing parameter value 1 will get hotkey_all_mask (the same like
> > > > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > > that case there is no adaptive keyboard available.
> > > >
> > > > Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> > > > Signed-off-by: Lyude <cpaul@redhat.com>
> > > > Tested-by: Lyude <cpaul@redhat.com>
> > > > Tested-by: Marco Trevisan <marco@ubuntu.com>
> > > > Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> > >
> > > Can you also Cc: stable@vger.kernel.org so that it can be imported
> > > there once merged?
> >
> > It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
> >
> > Henrique, do you want to weigh in on whether this goes back to stable?
>
> It should be in a bunch of -rc kernel releases before we even consider
> it.
>
> > One thing I could do is include this in my 4.7-rc fixes branch instead of
> > waiting for 4.8.
>
> If Linus will take it, I don't see a problem with that.

I'll do that.

--
Darren Hart
Intel Open Source Technology Center