Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY version 0x200

Darren Hart
2016-06-07T21:43:13Z

On Tue, Jun 07, 2016 at 05:10:51PM -0400, Lyude Paul wrote:
> Managed to find someone in the office with one of these laptops and it looks
> like the adaptive keyboard works perfectly with this patch, so I can give my t-
> b:
>
> Tested-by: Lyude Paul <cpaul@redhat.com>
>
> Cheers,
> Lyude
>
> On Tue, 2016-06-07 at 13:02 -0400, Lyude Paul wrote:
> > Since nothing's really happened with this patch for a while I figured I'd take
> > over trying to get this upstream.
> >
> > Regarding testing: This seems to work fine on the 60 series laptops, and works
> > fine on previous generations. The one thing I haven't been able to test is an
> > X1
> > carbon with an adaptive keyboard since I don't seem to have one readily
> > available here. I'm doing a search around the office to try to find someone
> > who
> > didn't throw theirs away yet so hopefully I should be able to get back to you
> > on
> > that soon.
> >
> > To Dennis: I took the liberty of doing a review of your patch and some
> > testing.
> > There's a few things that need changing, I've outlined them below: (for the
> > future, it's recommended to send patches for the kernel inline in emails to
> > make
> > them easier to review).

If someone would please update the patch with any pending changes from review
and so it follows the rules in Documentation/SubmittingPatches, including the
complete list of recipients on Cc, we can move this forward.

Regards,

--
Darren Hart
Intel Open Source Technology Center