From: David Kershner <david.kershner@unisys.com>
To: <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <david.kershner@unisys.com>,
<gregkh@linuxfoundation.org>, <erik.arfvidson@unisys.com>,
<timothy.sell@unisys.com>, <hofrat@osadl.org>,
<dzickus@redhat.com>, <jes.sorensen@redhat.com>,
<alexander.curtin@unisys.com>, <janani.rvchndrn@gmail.com>,
<sudipm.mukherjee@gmail.com>, <prarit@redhat.com>,
<david.binder@unisys.com>, <nhorman@redhat.com>,
<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<driverdev-devel@linuxdriverproject.org>,
<sparmaintainer@unisys.com>
Cc: Bryan Thompson <bryan.thompson@unisys.com>
Subject: [PATCH v4 13/29] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements
Date: Wed, 8 Jun 2016 17:14:07 -0400 [thread overview]
Message-ID: <1465420463-24982-14-git-send-email-david.kershner@unisys.com> (raw)
In-Reply-To: <1465420463-24982-1-git-send-email-david.kershner@unisys.com>
From: Bryan Thompson <bryan.thompson@unisys.com>
The driver that is now visorbus started out as multiple separate drivers,
and when they were merged the EXPORT_SYMBOL statements that were required
for separate drivers were left in the code. This patch removes those now
unnecessary exports.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 1 -
drivers/staging/unisys/visorbus/visorchannel.c | 17 -----------------
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
3 files changed, 20 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 2e0eb03..f7f5986 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -721,7 +721,6 @@ visorbus_clear_channel(struct visor_device *dev, unsigned long offset, u8 ch,
{
return visorchannel_clear(dev->visorchannel, offset, ch, nbytes);
}
-EXPORT_SYMBOL_GPL(visorbus_clear_channel);
/** We don't really have a real interrupt, so for now we just call the
* interrupt function periodically...
diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c
index 4337358..1f626c3 100644
--- a/drivers/staging/unisys/visorbus/visorchannel.c
+++ b/drivers/staging/unisys/visorbus/visorchannel.c
@@ -148,7 +148,6 @@ visorchannel_create(u64 physaddr, unsigned long channel_bytes,
return visorchannel_create_guts(physaddr, channel_bytes, gfp, 0, guid,
false);
}
-EXPORT_SYMBOL_GPL(visorchannel_create);
struct visorchannel *
visorchannel_create_with_lock(u64 physaddr, unsigned long channel_bytes,
@@ -157,7 +156,6 @@ visorchannel_create_with_lock(u64 physaddr, unsigned long channel_bytes,
return visorchannel_create_guts(physaddr, channel_bytes, gfp, 0, guid,
true);
}
-EXPORT_SYMBOL_GPL(visorchannel_create_with_lock);
void
visorchannel_destroy(struct visorchannel *channel)
@@ -171,21 +169,18 @@ visorchannel_destroy(struct visorchannel *channel)
}
kfree(channel);
}
-EXPORT_SYMBOL_GPL(visorchannel_destroy);
u64
visorchannel_get_physaddr(struct visorchannel *channel)
{
return channel->physaddr;
}
-EXPORT_SYMBOL_GPL(visorchannel_get_physaddr);
ulong
visorchannel_get_nbytes(struct visorchannel *channel)
{
return channel->nbytes;
}
-EXPORT_SYMBOL_GPL(visorchannel_get_nbytes);
char *
visorchannel_uuid_id(uuid_le *guid, char *s)
@@ -193,28 +188,24 @@ visorchannel_uuid_id(uuid_le *guid, char *s)
sprintf(s, "%pUL", guid);
return s;
}
-EXPORT_SYMBOL_GPL(visorchannel_uuid_id);
char *
visorchannel_id(struct visorchannel *channel, char *s)
{
return visorchannel_uuid_id(&channel->guid, s);
}
-EXPORT_SYMBOL_GPL(visorchannel_id);
char *
visorchannel_zoneid(struct visorchannel *channel, char *s)
{
return visorchannel_uuid_id(&channel->chan_hdr.zone_uuid, s);
}
-EXPORT_SYMBOL_GPL(visorchannel_zoneid);
u64
visorchannel_get_clientpartition(struct visorchannel *channel)
{
return channel->chan_hdr.partition_handle;
}
-EXPORT_SYMBOL_GPL(visorchannel_get_clientpartition);
int
visorchannel_set_clientpartition(struct visorchannel *channel,
@@ -223,7 +214,6 @@ visorchannel_set_clientpartition(struct visorchannel *channel,
channel->chan_hdr.partition_handle = partition_handle;
return 0;
}
-EXPORT_SYMBOL_GPL(visorchannel_set_clientpartition);
uuid_le
visorchannel_get_uuid(struct visorchannel *channel)
@@ -243,7 +233,6 @@ visorchannel_read(struct visorchannel *channel, ulong offset,
return 0;
}
-EXPORT_SYMBOL_GPL(visorchannel_read);
int
visorchannel_write(struct visorchannel *channel, ulong offset,
@@ -265,7 +254,6 @@ visorchannel_write(struct visorchannel *channel, ulong offset,
return 0;
}
-EXPORT_SYMBOL_GPL(visorchannel_write);
int
visorchannel_clear(struct visorchannel *channel, ulong offset, u8 ch,
@@ -301,14 +289,12 @@ out_free_page:
free_page((unsigned long)buf);
return err;
}
-EXPORT_SYMBOL_GPL(visorchannel_clear);
void __iomem *
visorchannel_get_header(struct visorchannel *channel)
{
return (void __iomem *)&channel->chan_hdr;
}
-EXPORT_SYMBOL_GPL(visorchannel_get_header);
/** Return offset of a specific SIGNAL_QUEUE_HEADER from the beginning of a
* channel header
@@ -522,7 +508,6 @@ visorchannel_signalqueue_slots_avail(struct visorchannel *channel, u32 queue)
slots_avail = sig_hdr.max_signals - slots_used;
return (int)slots_avail;
}
-EXPORT_SYMBOL_GPL(visorchannel_signalqueue_slots_avail);
int
visorchannel_signalqueue_max_slots(struct visorchannel *channel, u32 queue)
@@ -533,7 +518,6 @@ visorchannel_signalqueue_max_slots(struct visorchannel *channel, u32 queue)
return 0;
return (int)sig_hdr.max_signals;
}
-EXPORT_SYMBOL_GPL(visorchannel_signalqueue_max_slots);
static void
sigqueue_debug(struct signal_queue_header *q, int which, struct seq_file *seq)
@@ -632,4 +616,3 @@ visorchannel_debug(struct visorchannel *channel, int num_queues,
seq_printf(seq, "--- End channel @0x%-16.16Lx for 0x%lx bytes ---\n",
addr + off, nbytes);
}
-EXPORT_SYMBOL_GPL(visorchannel_debug);
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index b668b80..b5942c6 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -682,7 +682,6 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
vdev = to_visor_device(dev);
return vdev;
}
-EXPORT_SYMBOL(visorbus_get_device_by_id);
void
visorchipset_register_busdev(
@@ -707,7 +706,6 @@ visorchipset_register_busdev(
up(¬ifier_lock);
}
-EXPORT_SYMBOL_GPL(visorchipset_register_busdev);
static void
chipset_init(struct controlvm_message *inmsg)
--
1.9.1
next prev parent reply other threads:[~2016-06-08 21:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 21:13 [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to drivers/virt David Kershner
2016-06-08 21:13 ` [PATCH v4 01/29] staging: unisys: visorbus: remove return values for write_vbus functions David Kershner
2016-06-08 21:13 ` [PATCH v4 02/29] staging: unisys: visorbus: check parahotplug_request_complete_result David Kershner
2016-06-08 21:13 ` [PATCH v4 03/29] staging: unisys: visorbus: remove unused module parameters David Kershner
2016-06-08 21:13 ` [PATCH v4 04/29] staging: unisys: visorbus: remove unused struct David Kershner
2016-06-08 21:13 ` [PATCH v4 05/29] staging: unisys: visorbus: modify format string to match argument David Kershner
2016-06-08 21:14 ` [PATCH v4 06/29] staging: unisys: visornic: Correct comment spelling mistake David Kershner
2016-06-08 21:14 ` [PATCH v4 07/29] staging: unisys: include: Remove thread-related enum members David Kershner
2016-06-08 21:14 ` [PATCH v4 08/29] staging: unisys: visorbus: removed unused periodic_test_workqueue David Kershner
2016-06-08 21:14 ` [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking David Kershner
2016-06-09 9:01 ` Thomas Gleixner
2016-06-09 12:03 ` Sell, Timothy C
2016-06-09 19:55 ` Thomas Gleixner
2016-06-09 20:30 ` Sell, Timothy C
2016-06-11 3:34 ` Sell, Timothy C
2016-06-08 21:14 ` [PATCH v4 10/29] staging: unisys: visorbus: use kernel timer instead of workqueue David Kershner
2016-06-08 21:14 ` [PATCH v4 11/29] staging: unisys: visorbus: remove periodic_work.h/.c David Kershner
2016-06-08 21:14 ` [PATCH v4 12/29] staging: unisys: visorbus: Make visordriver_callback_lock a mutex David Kershner
2016-06-08 21:14 ` David Kershner [this message]
2016-06-08 21:14 ` [PATCH v4 14/29] staging: unisys: visorbus: Remove unused functions David Kershner
2016-06-08 21:14 ` [PATCH v4 15/29] staging: unisys: Remove reference to unused STANDALONE_CLIENT David Kershner
2016-06-08 21:14 ` [PATCH v4 16/29] staging: unisys: visorbus: remove unused parameter from function David Kershner
2016-06-08 21:14 ` [PATCH v4 17/29] staging: unisys: visorbus: fix commenting in vbusdevinfo.h David Kershner
2016-06-08 21:14 ` [PATCH v4 18/29] staging: unisys: visorbus: fix commenting in visorbus_main.c David Kershner
2016-06-08 21:14 ` [PATCH v4 19/29] staging: unisys: visorbus: fix visorchannel.c comments David Kershner
2016-06-08 21:14 ` [PATCH v4 20/29] staging: unisys: visorbus: Rectify commenting in visorchipset.c David Kershner
2016-06-08 21:14 ` [PATCH v4 21/29] staging: unisys: visorbus: Move visorbus-unique functions to private header David Kershner
2016-06-08 21:14 ` [PATCH v4 22/29] staging: unisys: visorbus: rectify kerneldoc comment for struct David Kershner
2016-06-08 21:14 ` [PATCH v4 23/29] staging: unisys: visorbus: Remove notifier-related code from visorbus David Kershner
2016-06-08 21:14 ` [PATCH v4 24/29] staging: unisys: visorbus: Rename function to follow existing convention David Kershner
2016-06-08 21:14 ` [PATCH v4 25/29] staging: unisys: visorbus: fix visorbus_private.h comments David Kershner
2016-06-08 21:14 ` [PATCH v4 26/29] staging: unisys: Move vbushelper.h to visorbus directory David Kershner
2016-06-08 21:14 ` [PATCH v4 27/29] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2016-06-08 21:14 ` [PATCH v4 28/29] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2016-06-08 21:14 ` [PATCH v4 29/29] drivers: Add visorbus to the drivers/virt directory David Kershner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465420463-24982-14-git-send-email-david.kershner@unisys.com \
--to=david.kershner@unisys.com \
--cc=alexander.curtin@unisys.com \
--cc=bryan.thompson@unisys.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david.binder@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=dzickus@redhat.com \
--cc=erik.arfvidson@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=hpa@zytor.com \
--cc=janani.rvchndrn@gmail.com \
--cc=jes.sorensen@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=prarit@redhat.com \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tglx@linutronix.de \
--cc=timothy.sell@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).