From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757972AbcFHVPc (ORCPT ); Wed, 8 Jun 2016 17:15:32 -0400 Received: from mail1.bemta8.messagelabs.com ([216.82.243.197]:56597 "EHLO mail1.bemta8.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756022AbcFHVOm (ORCPT ); Wed, 8 Jun 2016 17:14:42 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRWlGSWpSXmKPExsVywNY2U3dbV0S 4wcVmTYuFbUtYLC7vmsPmwOTxeZNcAGMUa2ZeUn5FAmvGuSnSBQskKu4f/8rawHhMpIuRi0NI YBejRN/rSWwQzn5GiR+/nkI5lxgl5k05zQThrGWUOLf4HyOEs4VRonHuI6AMJwebgIHEzDt32 UFsEYHzLBJPb+V2MXJwCAskSTy9lAISZhFQkXhycD8riM0r4ClxcvlcFhBbQkBO4uSxyWBxTg EviYe/1oKNFAKqaXn3mB3CVpM4fPYRG8hICYFgiU0HVSDGCEqcnPkEbAyzgITEwRcvmCcwCs5 CkpqFJLWAkWkVo0ZxalFZapGuoZleUlFmekZJbmJmjq6hgYVebmpxcWJ6ak5iUrFecn7uJkZg oNYzMDDuYJyw2/0QoyQHk5Iob5l7RLgQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd7kTqCcYFFqe mpFWmYOMGZg0hIcPEoivCdB0rzFBYm5xZnpEKlTjIpS4ryLQRICIImM0jy4NlicXmKUlRLmZW RgYBDiKUgtys0sQZV/xSjOwagkzLsMZApPZl4J3PRXQIuZgBYvPxIOsrgkESEl1cCYViPu/3e Ro/IDBZElOezBm1iZW4tUPZ9tkN+WIrx0ipV/QL/b05hT+mEri17xnuC0P/hL38h1hpLw6zML rUu0t2yPKQtzfvDv5iaNCTyntrSeW9Y1K55525Hc/urHOqechRXa5LckPVgVea2fddu6xef53 Mr8lN6sMt4XyXROS6ZG8NVmrQIlluKMREMt5qLiRABH3YcEzgIAAA== X-Env-Sender: David.Kershner@unisys.com X-Msg-Ref: server-14.tower-46.messagelabs.com!1465420467!29094340!11 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked From: David Kershner To: , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v4 01/29] staging: unisys: visorbus: remove return values for write_vbus functions Date: Wed, 8 Jun 2016 17:13:55 -0400 Message-ID: <1465420463-24982-2-git-send-email-david.kershner@unisys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465420463-24982-1-git-send-email-david.kershner@unisys.com> References: <1465420463-24982-1-git-send-email-david.kershner@unisys.com> X-OriginalArrivalTime: 08 Jun 2016 21:14:27.0325 (UTC) FILETIME=[BD4252D0:01D1C1CA] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erik Arfvidson This patch removes the return values from the write_vbus_* channel functions. Nobody was checking the return values and the value stored into the vbus info is not critical to the functioning of the device. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 33 ++++++++++++++----------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c index d32b898..2ed9628 100644 --- a/drivers/staging/unisys/visorbus/visorbus_main.c +++ b/drivers/staging/unisys/visorbus/visorbus_main.c @@ -866,9 +866,12 @@ get_vbus_header_info(struct visorchannel *chan, /* Write the contents of to the struct * spar_vbus_channel_protocol.chp_info. + * + * Returns void since this is debug information and not needed for + * device functionality. */ -static int +static void write_vbus_chp_info(struct visorchannel *chan, struct spar_vbus_headerinfo *hdr_info, struct ultra_vbus_deviceinfo *info) @@ -876,18 +879,19 @@ write_vbus_chp_info(struct visorchannel *chan, int off = sizeof(struct channel_header) + hdr_info->chp_info_offset; if (hdr_info->chp_info_offset == 0) - return -EFAULT; + return; - if (visorchannel_write(chan, off, info, sizeof(*info)) < 0) - return -EFAULT; - return 0; + visorchannel_write(chan, off, info, sizeof(*info)); } /* Write the contents of to the struct * spar_vbus_channel_protocol.bus_info. + * + * Returns void since this is debug information and not needed for + * device functionality. */ -static int +static void write_vbus_bus_info(struct visorchannel *chan, struct spar_vbus_headerinfo *hdr_info, struct ultra_vbus_deviceinfo *info) @@ -895,17 +899,18 @@ write_vbus_bus_info(struct visorchannel *chan, int off = sizeof(struct channel_header) + hdr_info->bus_info_offset; if (hdr_info->bus_info_offset == 0) - return -EFAULT; + return; - if (visorchannel_write(chan, off, info, sizeof(*info)) < 0) - return -EFAULT; - return 0; + visorchannel_write(chan, off, info, sizeof(*info)); } /* Write the contents of to the * struct spar_vbus_channel_protocol.dev_info[]. + * + * Returns void since this is debug information and not needed for + * device functionality. */ -static int +static void write_vbus_dev_info(struct visorchannel *chan, struct spar_vbus_headerinfo *hdr_info, struct ultra_vbus_deviceinfo *info, int devix) @@ -915,11 +920,9 @@ write_vbus_dev_info(struct visorchannel *chan, (hdr_info->device_info_struct_bytes * devix); if (hdr_info->dev_info_offset == 0) - return -EFAULT; + return; - if (visorchannel_write(chan, off, info, sizeof(*info)) < 0) - return -EFAULT; - return 0; + visorchannel_write(chan, off, info, sizeof(*info)); } /* For a child device just created on a client bus, fill in -- 1.9.1