From: Michael Neuling <mikey@neuling.org>
To: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>,
benh@au1.ibm.com, mpe@ellerman.id.au
Cc: ego@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction
Date: Thu, 09 Jun 2016 08:22:34 +1000 [thread overview]
Message-ID: <1465424554.17932.14.camel@neuling.org> (raw)
In-Reply-To: <57584F60.7010504@linux.vnet.ibm.com>
On Wed, 2016-06-08 at 22:31 +0530, Shreyas B Prabhu wrote:
> Hi Ben,
>
> Sorry for the delayed response.
>
> On 06/06/2016 03:58 AM, Benjamin Herrenschmidt wrote:
> >
> > On Thu, 2016-06-02 at 07:38 -0500, Shreyas B. Prabhu wrote:
> > >
> > > @@ -61,8 +72,13 @@ save_sprs_to_stack:
> > > * Note all register i.e per-core, per-subcore or per-thread
> > > is saved
> > > * here since any thread in the core might wake up first
> > > */
> > > +BEGIN_FTR_SECTION
> > > + mfspr r3,SPRN_PTCR
> > > + std r3,_PTCR(r1)
> > > +FTR_SECTION_ELSE
> > > mfspr r3,SPRN_SDR1
> > > std r3,_SDR1(r1)
> > > +ALT_FTR_SECTION_END_IFSET(CPU_FTR_ARCH_300)
> > This is the only new SPR we care about in P9 ?
> >
> After reviewing ISA again, I've identified LMRR, LMSER and ASDR also
> need to be restored. I've fixed this in v6.
LMRR and LMSER are used the load monitored patch set. There they will get
restored when we context switch back to userspace. It probably doesn't
hurt that much but you don't need to restore them here.
They are not used in the kernel.
It escapes me what ASDR is right now.
Mikey
next prev parent reply other threads:[~2016-06-08 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 12:38 [PATCH v5 00/11] powerpc/powernv/cpuidle: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 01/11] powerpc/powernv: Use PNV_THREAD_WINKLE macro while requesting for winkle Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 02/11] powerpc/kvm: make hypervisor state restore a function Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 03/11] powerpc/powernv: Rename idle_power7.S to idle_power_common.S Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 04/11] powerpc/powernv: Rename reusable idle functions to hardware agnostic names Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 05/11] powerpc/powernv: Make pnv_powersave_common more generic Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 06/11] powerpc/powernv: abstraction for saving SPRs before entering deep idle states Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 07/11] powerpc/powernv: set power_save func after the idle states are initialized Shreyas B. Prabhu
2016-06-02 12:38 ` [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction Shreyas B. Prabhu
2016-06-05 22:28 ` Benjamin Herrenschmidt
2016-06-08 17:01 ` Shreyas B Prabhu
2016-06-08 22:22 ` Michael Neuling [this message]
2016-06-09 4:42 ` Sam Bobroff
2016-06-09 16:09 ` Shreyas B Prabhu
2016-06-02 12:38 ` [PATCH v5 09/11] cpuidle/powernv: Use CPUIDLE_STATE_MAX instead of MAX_POWERNV_IDLE_STATES Shreyas B. Prabhu
2016-06-02 12:39 ` [PATCH v5 10/11] cpuidle/powernv: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-06-02 12:39 ` [PATCH v5 11/11] powerpc/powernv: Use deepest stop state when cpu is offlined Shreyas B. Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465424554.17932.14.camel@neuling.org \
--to=mikey@neuling.org \
--cc=benh@au1.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox