Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

joro
2016-06-15T11:56:11Z

On Thu, Jun 09, 2016 at 03:48:44PM +0000, Vesely, Jan wrote:
> On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote:
> > From: Jan Vesely <jan.vesely@amd.com>
> >
> > Signed-off-by: Jan Vesely <jan.vesely@amd.com>
> > ---
> >  drivers/iommu/amd_iommu.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> > index 17c76f2..4ff5e40 100644
> > --- a/drivers/iommu/amd_iommu.c
> > +++ b/drivers/iommu/amd_iommu.c
> > @@ -3016,6 +3016,7 @@ static void protection_domain_free(struct
> > protection_domain *domain)
> >
> >   del_domain_from_list(domain);
> >
> > + mutex_destroy(&domain->api_lock);
> >   if (domain->id)
> >   domain_id_free(domain->id);
> >
>
> ping

Your patches lack commit messages, please add a more detailed
description of what you are fixing and why. Please also add 'Fixes:'
tags when resubmitting. The changes itself look good to me.

Joerg