From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933278AbcFJQDm (ORCPT ); Fri, 10 Jun 2016 12:03:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:59021 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932946AbcFJQDk (ORCPT ); Fri, 10 Jun 2016 12:03:40 -0400 Message-ID: <1465574394.3339.0.camel@suse.com> Subject: Re: [PATCH v7] input: tablet: add Pegasus Notetaker tablet driver From: Oliver Neukum To: Martin Kepplinger Cc: dmitry.torokhov@gmail.com, kernel-testers@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Fri, 10 Jun 2016 17:59:54 +0200 In-Reply-To: <575AC03C.2010306@posteo.de> References: <1464785703-5555-1-git-send-email-martink@posteo.de> <1465484429.17248.13.camel@suse.com> <575AC03C.2010306@posteo.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-10 at 15:27 +0200, Martin Kepplinger wrote: > >> + input_set_abs_params(input_dev, ABS_X, -1500, 1500, 8, 0); > >> + input_set_abs_params(input_dev, ABS_Y, 1600, 3000, 8, 0); > >> + > >> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE); > > > > If you need to do this here. It is also needed in reset_resume() > > > > This is done in open() now. You must do it conditionally in reset_resume() then. Regards Oliver