Re: [PATCH RFT] regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed

Srinivas Kandagatla
2016-06-15T08:27:37Z

Hi Mark,

On 15/06/16 03:21, Axel Lin wrote:
> Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is
> wrong because it is used for fixed regulator without any linear range.
> The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV
> set and n_voltages = 1. In this case, regulator_list_voltage() can return
> rdev->desc->fixed_uV without .list_voltage implementation.
>
> Fixes: 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback")

TBH, 3bfbb4d1a480 patch was never in the mailing list, am sure there is
some confusion while applying other patches.

May be a8a47540ebe3 got re-applied, without any errors/warning I guess.

These are the only 2 patches which were submitted in mailing list and
which made into next.

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a8a47540ebe32f1733eebc3e5699af580ceaa3f5

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d1e44b6b2823f1751ffe7e7589f545f05cfe2095

Thanks,
srini

> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 526bf23..6c7fe477 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -152,7 +152,6 @@ static const struct regulator_ops rpm_smps_ldo_ops_fixed = {
> .enable = rpm_reg_enable,
> .disable = rpm_reg_disable,
> .is_enabled = rpm_reg_is_enabled,
> - .list_voltage = regulator_list_voltage_linear_range,
>
> .get_voltage = rpm_reg_get_voltage,
> .set_voltage = rpm_reg_set_voltage,
>