From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Dan O'Donovan" <dan@emutex.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison
Date: Wed, 15 Jun 2016 12:17:10 +0300 [thread overview]
Message-ID: <1465982230.30123.106.camel@linux.intel.com> (raw)
In-Reply-To: <20160615080653.GA16023@gmail.com>
On Wed, 2016-06-15 at 10:06 +0200, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > +static const struct devs_id pcal9555a_1_dev_id __initconst = {
> > + .name = "pcal9555a-1",
> > + .type = SFI_DEV_TYPE_I2C,
> > + .delay = 1,
> > + .get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_2_dev_id __initconst = {
> > + .name = "pcal9555a-2",
> > + .type = SFI_DEV_TYPE_I2C,
> > + .delay = 1,
> > + .get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_3_dev_id __initconst = {
> > + .name = "pcal9555a-3",
> > + .type = SFI_DEV_TYPE_I2C,
> > + .delay = 1,
> > + .get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_4_dev_id __initconst = {
> > + .name = "pcal9555a-4",
> > + .type = SFI_DEV_TYPE_I2C,
> > + .delay = 1,
> > + .get_platform_data = &pcal9555a_platform_data,
> > +};
>
> I have the same complaint as yesterday. Going forward could we please
> get nice
> structure initializers in all future patches? :)
Oops, indeed. Sorry, will send new version soon.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-06-15 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 23:11 [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison Andy Shevchenko
2016-06-15 8:06 ` Ingo Molnar
2016-06-15 9:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465982230.30123.106.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan@emutex.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox