From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753289AbcFOJPx (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 05:15:53 -0400
Received: from mga04.intel.com ([192.55.52.120]:32057 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752789AbcFOJPv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 05:15:51 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,475,1459839600"; 
   d="scan'208";a="828436246"
Message-ID: <1465982230.30123.106.camel@linux.intel.com>
Subject: Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on
 Edison
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        "Dan O'Donovan" <dan@emutex.com>, linux-kernel@vger.kernel.org
Date: Wed, 15 Jun 2016 12:17:10 +0300
In-Reply-To: <20160615080653.GA16023@gmail.com>
References: <1465945918-27104-1-git-send-email-andriy.shevchenko@linux.intel.com>
	 <20160615080653.GA16023@gmail.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.3-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-06-15 at 10:06 +0200, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > +static const struct devs_id pcal9555a_1_dev_id __initconst = {
> > +	.name = "pcal9555a-1",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_2_dev_id __initconst = {
> > +	.name = "pcal9555a-2",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_3_dev_id __initconst = {
> > +	.name = "pcal9555a-3",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_4_dev_id __initconst = {
> > +	.name = "pcal9555a-4",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> 
> I have the same complaint as yesterday. Going forward could we please
> get nice 
> structure initializers in all future patches? :)

Oops, indeed. Sorry, will send new version soon.

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy