From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933036AbcFOVd5 (ORCPT ); Wed, 15 Jun 2016 17:33:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:14618 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbcFOVdy (ORCPT ); Wed, 15 Jun 2016 17:33:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,477,1459839600"; d="scan'208";a="988290758" From: "Jiang, Dave" To: "Allen.Hubbe@emc.com" , "logang@deltatee.com" , "jdmason@kudzu.us" CC: "linux-kernel@vger.kernel.org" , "shuahkh@osg.samsung.com" , "sudipm.mukherjee@gmail.com" , "linux-kselftest@vger.kernel.org" , "arnd@arndb.de" , "linux-ntb@googlegroups.com" Subject: Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down. Thread-Topic: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down. Thread-Index: AQHRx0yreFHaugVqjUOT/s57Otd2Wp/rgeUA Date: Wed, 15 Jun 2016 21:33:52 +0000 Message-ID: <1466026416.16234.262.camel@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [143.182.137.38] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5FLY2JT029262 On Wed, 2016-06-15 at 15:26 -0600, Logan Gunthorpe wrote: > When the link goes down, the link_is_up flag did not return to > false. This could have caused some subtle corner case bugs > when the link goes up and down quickly. > > Signed-off-by: Logan Gunthorpe Acked-by: Dave Jiang And all the other ntb_perf patches since there were no additional changes.  > --- >  drivers/ntb/test/ntb_perf.c | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/drivers/ntb/test/ntb_perf.c > b/drivers/ntb/test/ntb_perf.c > index f0784e5..ae9d1b2 100644 > --- a/drivers/ntb/test/ntb_perf.c > +++ b/drivers/ntb/test/ntb_perf.c > @@ -557,6 +557,8 @@ static void perf_link_cleanup(struct work_struct > *work) >   >   if (!perf->link_is_up) >   cancel_delayed_work_sync(&perf->link_work); > + > + perf->link_is_up = false; >  } >   >  static int perf_setup_mw(struct ntb_dev *ntb, struct perf_ctx *perf) > --  > 2.1.4 >