From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754088AbcFPK7b (ORCPT ); Thu, 16 Jun 2016 06:59:31 -0400 Received: from mail-am1on0124.outbound.protection.outlook.com ([157.56.112.124]:14848 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751659AbcFPK73 (ORCPT ); Thu, 16 Jun 2016 06:59:29 -0400 X-Greylist: delayed 906 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jun 2016 06:59:28 EDT From: Marcel Ziswiler To: "stefan@agner.ch" , "shawnguo@kernel.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "devicetree@vger.kernel.org" , "fabio.estevam@nxp.com" , Max Krummenacher , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" Subject: Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support Thread-Topic: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support Thread-Index: AQHRwS64vmiB5mk9OE6nJGleTLJ/q5/lIowAgAZ9fQCAAFWoAA== Date: Thu, 16 Jun 2016 10:44:18 +0000 Message-ID: <1466073856.3884.11.camel@toradex.com> References: <20160608023709.32090-1-stefan@agner.ch> <20160608023709.32090-4-stefan@agner.ch> <20160612023100.GW20243@tiger> <59f88a185c67034087f3eabf88da6c8c@agner.ch> In-Reply-To: <59f88a185c67034087f3eabf88da6c8c@agner.ch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [46.140.72.82] x-ms-office365-filtering-correlation-id: 5f103ab6-3577-4b3d-e19d-08d395d32b65 x-microsoft-exchange-diagnostics: 1;HE1PR05MB1386;6:2aAthcUvsekmXgyHsYRE5l+c+KyTFgJ3tKeeF2ld8G2c8gynMZAstVkC11YZ2WwreYYdJezeWsE+zStTPIyPxH0CegxwhwvgB0bhMKQjpzNMZOX1KswrIlf+SBgVZ6Upax+PKsTyj4HP2VIp+r9gbYYi/Y87ZZT9PPQ1AxQn4HNvC+/n/irDAQMecnEBLU1p/33x7o0ssXjcX/Yzm4UuOCRgKLMTWrrUHtouuWvtVIGnufSZMkeQiH1Ym5x5Qs7sm34nQrygQtZIhoRFgbvZOeMGQ1CmA4XgLUgeNrMPNCg=;5:CJF/9BiIOqfMMZgKwFa/3m96WkW9UkVII/Di/xwwn7wBiUki4xTqXum0NKhBUSWVrnoBlwREdMoC3lqJNqWYyb/+z8AfyIqE77BR06LN+KrnmY7mZn+CNCEv01urLPylVPCDMQTHmowbyb8TEKdTdA==;24:ayJ4V/8KTDQr3A3mTTI+7wqNouz9RAWi0EieMqJHA7hQTpbIlF/6+y1JGvHQUczT1cgIBBCLXAN4YuTeqPmdPAg9svz7QrAs7y1F6WpeQOM=;7:e8jBKACaJRkkofEBPd+JMZ8dGx7/X8nHfb0686+HJPFdbed9uPPP7vpQpXZ6Wv2ENwUDXwrdBqsDhtmDKhsqn/YekFeB70v+2v2WL1sLoK8COvWrmxnWM+y6bc9xbWw2frpsQP3+9GZnaZudRWVXTN1k1ZEqmIYPcy4My4V5Oe/Z0iRdLWp7Sr98+zC7k8i79tyQn0Bdb3ZeEPHIs4XLeA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1386; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:HE1PR05MB1386;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1386; x-forefront-prvs: 09752BC779 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(76104003)(24454002)(199003)(377424004)(189002)(5004730100002)(86362001)(68736007)(5008740100001)(15975445007)(101416001)(92566002)(77096005)(6116002)(33646002)(3280700002)(93886004)(102836003)(2900100001)(36756003)(105586002)(122556002)(2950100001)(3660700001)(3846002)(586003)(103116003)(81156014)(4326007)(2906002)(8666005)(8676002)(10400500002)(106356001)(50986999)(106116001)(81166006)(97736004)(87936001)(76176999)(54356999)(2501003)(189998001)(11100500001)(5001770100001)(19580395003)(8936002)(66066001)(5002640100001)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1386;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2016 10:44:18.2722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1386 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5GAxbi0000591 Sali Stefan On Wed, 2016-06-15 at 22:37 -0700, Stefan Agner wrote: > On 2016-06-11 19:31, Shawn Guo wrote: > > > > On Tue, Jun 07, 2016 at 07:37:09PM -0700, Stefan Agner wrote: > > > > > > > > > > > +/ { > > > + model = "Toradex Colibri iMX7D on Colibri Evaluation > > > Board V3"; > > > + compatible = "toradex,colibri_imx7d-eval", > > > "toradex,colibri_imx7d", \ > > We always use hyphen than underscore in compatible string. > We always used underscores, this goes back to the first Colibri > specific > device tree: tegra20-iris-512.dts. > > I would rather prefer to not change this for the sake of > consistency... > What do you think? I have been there before when submitting a first Apalis TK1 version: https://lkml.org/lkml/2016/5/16/288 Upon Rob Herring's suggestion I changed it now all to dashes: https://lkml.org/lkml/2016/5/27/399 Even in our downstream U-Boot: http://git.toradex.com/cgit/u-boot-toradex.git/commit/?h=2015.04-torade x-next&id=4ae2e657f3350422ad81b1632de156bdd9517206 Of course for Colibri iMX7 one could argue that we already sold a couple hundred pieces still using underscores. However I guess we could still change to dashes now as those were all prototype, sample and/or beta. Cheers Marcel