From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: ming.lei@canonical.com, akpm@linux-foundation.org,
mmarek@suse.com, gregkh@linuxfoundation.org, bp@alien8.de,
chunkeey@googlemail.com
Cc: linux-kernel@vger.kernel.org, markivx@codeaurora.org,
stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com,
broonie@kernel.org, tiwai@suse.de, johannes@sipsolutions.net,
hauke@hauke-m.de, jwboyer@fedoraproject.org,
dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com,
torvalds@linux-foundation.org, luto@amacapital.net,
fengguang.wu@intel.com, rpurdie@rpsys.net, ki@samsung.com,
Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, teg@jklm.no,
dhowells@redhat.com, keescook@chromium.org, tj@kernel.org,
daniel.vetter@ffwll.ch, corbet@lwn.net,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2 2/8] lib/test_firmware.c: use late_initcall()
Date: Thu, 16 Jun 2016 16:59:13 -0700 [thread overview]
Message-ID: <1466121559-22363-3-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1466121559-22363-1-git-send-email-mcgrof@kernel.org>
When expanding test coverage of firmware_class with the sysdata
API test driver we get a crash when CONFIG_TEST_FIRMWARE=y,
only a combination produces a panic however. This fixes it.
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at lib/kobject.c:597 kobject_get+0x4d/0x80
kobject: '(null)' (ffffea0000722850): is not initialized, yet kobject_get() is being called.
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.6.0-rc3-1-default+ #127
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS by qemu-project.org 04/01/2014
0000000000000000 ffff88001e223c48 ffffffff813948c1 ffff88001e223c98
0000000000000000 ffff88001e223c88 ffffffff8107eecb 00000255024080c0
ffff88001f837810 ffffea0000722840 0000000000000000 ffff88001f837800
Call Trace:
[<ffffffff813948c1>] dump_stack+0x63/0x82
[<ffffffff8107eecb>] __warn+0xcb/0xf0
[<ffffffff8107ef3f>] warn_slowpath_fmt+0x4f/0x60
[<ffffffff814d6783>] ? device_private_init+0x23/0x70
[<ffffffff81396cdd>] kobject_get+0x4d/0x80
[<ffffffff814d68aa>] device_add+0xda/0x680
[<ffffffff814d7040>] device_create_groups_vargs+0xe0/0xf0
[<ffffffff81d82675>] ? test_firmware_init+0xb2/0xb2
[<ffffffff814d70f6>] device_create_with_groups+0x36/0x40
[<ffffffff813ae6d1>] ? test_dev_get_name+0x91/0xd0
[<ffffffff814ad3d5>] misc_register+0x145/0x180
[<ffffffff81d826a8>] test_sysdata_init+0x33/0xc8
[<ffffffff81002123>] do_one_initcall+0xb3/0x200
[<ffffffff8109d805>] ? parse_args+0x295/0x4b0
[<ffffffff81d3e12b>] kernel_init_freeable+0x183/0x20e
[<ffffffff816a1ace>] kernel_init+0xe/0x100
[<ffffffff816af062>] ret_from_fork+0x22/0x40
[<ffffffff816a1ac0>] ? rest_init+0x90/0x90
---[ end trace 3779de9087657326 ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at lib/kobject.c:597 kobject_get+0x4d/0x80
kobject: '(null)' (ffffea0000722850): is not initialized, yet kobject_get() is being called.
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.6.0-rc3-1-default+ #127
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS by qemu-project.org 04/01/2014
0000000000000000 ffff88001e223b70 ffffffff813948c1 ffff88001e223bc0
0000000000000000 ffff88001e223bb0 ffffffff8107eecb 00000255816af7cb
ffff88001f80c400 0000000000000000 ffffea0000722850 ffff88001f836800
Call Trace:
[<ffffffff813948c1>] dump_stack+0x63/0x82
[<ffffffff8107eecb>] __warn+0xcb/0xf0
[<ffffffff8107ef3f>] warn_slowpath_fmt+0x4f/0x60
[<ffffffff813a90e5>] ? find_next_bit+0x15/0x20
[<ffffffff81396cdd>] kobject_get+0x4d/0x80
[<ffffffff81397629>] kobject_add_internal+0x39/0x340
[<ffffffff811a9512>] ? kfree_const+0x22/0x30
[<ffffffff81397998>] kobject_add+0x68/0xb0
[<ffffffff8107ef3f>] ? warn_slowpath_fmt+0x4f/0x60
[<ffffffff814d5b3d>] get_device_parent.isra.19+0x10d/0x1d0
[<ffffffff814d68c1>] device_add+0xf1/0x680
[<ffffffff814d7040>] device_create_groups_vargs+0xe0/0xf0
[<ffffffff81d82675>] ? test_firmware_init+0xb2/0xb2
[<ffffffff814d70f6>] device_create_with_groups+0x36/0x40
[<ffffffff813ae6d1>] ? test_dev_get_name+0x91/0xd0
[<ffffffff814ad3d5>] misc_register+0x145/0x180
[<ffffffff81d826a8>] test_sysdata_init+0x33/0xc8
[<ffffffff81002123>] do_one_initcall+0xb3/0x200
[<ffffffff8109d805>] ? parse_args+0x295/0x4b0
[<ffffffff81d3e12b>] kernel_init_freeable+0x183/0x20e
[<ffffffff816a1ace>] kernel_init+0xe/0x100
[<ffffffff816af062>] ret_from_fork+0x22/0x40
[<ffffffff816a1ac0>] ? rest_init+0x90/0x90
---[ end trace 3779de9087657327 ]---
general protection fault: 0000 [#1] PREEMPT SMP
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
lib/test_firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_firmware.c b/lib/test_firmware.c
index a3e8ec3fb1c5..5f087a03e5f7 100644
--- a/lib/test_firmware.c
+++ b/lib/test_firmware.c
@@ -167,7 +167,7 @@ dereg:
return rc;
}
-module_init(test_firmware_init);
+late_initcall(test_firmware_init);
static void __exit test_firmware_exit(void)
{
--
2.8.2
next prev parent reply other threads:[~2016-06-16 23:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 23:59 [PATCH v2 0/8] firmware: add new sysdata API Luis R. Rodriguez
2016-06-16 23:59 ` [PATCH v2 1/8] firmware: add new extensible firmware API - sysdata_file_request*() Luis R. Rodriguez
2016-08-11 21:15 ` Bjorn Andersson
2016-08-12 15:25 ` Luis R. Rodriguez
2016-06-16 23:59 ` Luis R. Rodriguez [this message]
2016-06-16 23:59 ` [PATCH v2 3/8] selftests: firmware: only modprobe if driver is missing Luis R. Rodriguez
2016-06-16 23:59 ` [PATCH v2 4/8] selftests: firmware: send expected errors to /dev/null Luis R. Rodriguez
2016-06-16 23:59 ` [PATCH v2 5/8] test: add new sysdata_file_request*() loader tester Luis R. Rodriguez
2016-06-16 23:59 ` [PATCH v2 6/8] Documentation/firmware_class: add sysdata API converter SmPL patch Luis R. Rodriguez
2016-06-16 23:59 ` [PATCH v2 7/8] x86/microcode: convert to use sysdata API Luis R. Rodriguez
2016-06-16 23:59 ` [PATCH v2 8/8] p54: convert to " Luis R. Rodriguez
[not found] ` <CA+55aFyD+Xa2auP05=pBSxQc2qcuR858syMW5fiQKowbqbkDzQ@mail.gmail.com>
2016-06-17 1:36 ` Luis R. Rodriguez
2016-06-17 3:09 ` Linus Torvalds
2016-06-17 18:35 ` Luis R. Rodriguez
2016-08-10 18:32 ` Luis R. Rodriguez
2016-08-10 19:04 ` Arend Van Spriel
2016-08-10 19:17 ` Mark Brown
2016-08-10 19:40 ` Luis R. Rodriguez
2016-08-10 19:34 ` Luis R. Rodriguez
2016-06-17 23:40 ` [PATCH v2 0/8] firmware: add new " Luis R. Rodriguez
2016-06-18 0:32 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466121559-22363-3-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=Abhay_Salunke@dell.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=chunkeey@googlemail.com \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=keescook@chromium.org \
--cc=ki@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=markivx@codeaurora.org \
--cc=ming.lei@canonical.com \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=rpurdie@rpsys.net \
--cc=stephen.boyd@linaro.org \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox