From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754746AbcFPX7f (ORCPT ); Thu, 16 Jun 2016 19:59:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:41312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbcFPX7c (ORCPT ); Thu, 16 Jun 2016 19:59:32 -0400 From: "Luis R. Rodriguez" To: ming.lei@canonical.com, akpm@linux-foundation.org, mmarek@suse.com, gregkh@linuxfoundation.org, bp@alien8.de, chunkeey@googlemail.com Cc: linux-kernel@vger.kernel.org, markivx@codeaurora.org, stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com, broonie@kernel.org, tiwai@suse.de, johannes@sipsolutions.net, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, luto@amacapital.net, fengguang.wu@intel.com, rpurdie@rpsys.net, ki@samsung.com, Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, teg@jklm.no, dhowells@redhat.com, keescook@chromium.org, tj@kernel.org, daniel.vetter@ffwll.ch, corbet@lwn.net, "Luis R. Rodriguez" Subject: [PATCH v2 2/8] lib/test_firmware.c: use late_initcall() Date: Thu, 16 Jun 2016 16:59:13 -0700 Message-Id: <1466121559-22363-3-git-send-email-mcgrof@kernel.org> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1466121559-22363-1-git-send-email-mcgrof@kernel.org> References: <1466121559-22363-1-git-send-email-mcgrof@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When expanding test coverage of firmware_class with the sysdata API test driver we get a crash when CONFIG_TEST_FIRMWARE=y, only a combination produces a panic however. This fixes it. ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at lib/kobject.c:597 kobject_get+0x4d/0x80 kobject: '(null)' (ffffea0000722850): is not initialized, yet kobject_get() is being called. Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.6.0-rc3-1-default+ #127 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS by qemu-project.org 04/01/2014 0000000000000000 ffff88001e223c48 ffffffff813948c1 ffff88001e223c98 0000000000000000 ffff88001e223c88 ffffffff8107eecb 00000255024080c0 ffff88001f837810 ffffea0000722840 0000000000000000 ffff88001f837800 Call Trace: [] dump_stack+0x63/0x82 [] __warn+0xcb/0xf0 [] warn_slowpath_fmt+0x4f/0x60 [] ? device_private_init+0x23/0x70 [] kobject_get+0x4d/0x80 [] device_add+0xda/0x680 [] device_create_groups_vargs+0xe0/0xf0 [] ? test_firmware_init+0xb2/0xb2 [] device_create_with_groups+0x36/0x40 [] ? test_dev_get_name+0x91/0xd0 [] misc_register+0x145/0x180 [] test_sysdata_init+0x33/0xc8 [] do_one_initcall+0xb3/0x200 [] ? parse_args+0x295/0x4b0 [] kernel_init_freeable+0x183/0x20e [] kernel_init+0xe/0x100 [] ret_from_fork+0x22/0x40 [] ? rest_init+0x90/0x90 ---[ end trace 3779de9087657326 ]--- ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at lib/kobject.c:597 kobject_get+0x4d/0x80 kobject: '(null)' (ffffea0000722850): is not initialized, yet kobject_get() is being called. Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.6.0-rc3-1-default+ #127 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS by qemu-project.org 04/01/2014 0000000000000000 ffff88001e223b70 ffffffff813948c1 ffff88001e223bc0 0000000000000000 ffff88001e223bb0 ffffffff8107eecb 00000255816af7cb ffff88001f80c400 0000000000000000 ffffea0000722850 ffff88001f836800 Call Trace: [] dump_stack+0x63/0x82 [] __warn+0xcb/0xf0 [] warn_slowpath_fmt+0x4f/0x60 [] ? find_next_bit+0x15/0x20 [] kobject_get+0x4d/0x80 [] kobject_add_internal+0x39/0x340 [] ? kfree_const+0x22/0x30 [] kobject_add+0x68/0xb0 [] ? warn_slowpath_fmt+0x4f/0x60 [] get_device_parent.isra.19+0x10d/0x1d0 [] device_add+0xf1/0x680 [] device_create_groups_vargs+0xe0/0xf0 [] ? test_firmware_init+0xb2/0xb2 [] device_create_with_groups+0x36/0x40 [] ? test_dev_get_name+0x91/0xd0 [] misc_register+0x145/0x180 [] test_sysdata_init+0x33/0xc8 [] do_one_initcall+0xb3/0x200 [] ? parse_args+0x295/0x4b0 [] kernel_init_freeable+0x183/0x20e [] kernel_init+0xe/0x100 [] ret_from_fork+0x22/0x40 [] ? rest_init+0x90/0x90 ---[ end trace 3779de9087657327 ]--- general protection fault: 0000 [#1] PREEMPT SMP Signed-off-by: Luis R. Rodriguez --- lib/test_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_firmware.c b/lib/test_firmware.c index a3e8ec3fb1c5..5f087a03e5f7 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -167,7 +167,7 @@ dereg: return rc; } -module_init(test_firmware_init); +late_initcall(test_firmware_init); static void __exit test_firmware_exit(void) { -- 2.8.2