From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755054AbcFUH5i (ORCPT ); Tue, 21 Jun 2016 03:57:38 -0400 Received: from mail-am1on0126.outbound.protection.outlook.com ([157.56.112.126]:46238 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752024AbcFUH53 (ORCPT ); Tue, 21 Jun 2016 03:57:29 -0400 From: Marcel Ziswiler To: "swarren@wwwdotorg.org" , "thierry.reding@gmail.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux@armlinux.org.uk" , "gnurou@gmail.com" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v2] arm: tegra124: remove commas from unit addresses Thread-Topic: [PATCH v2] arm: tegra124: remove commas from unit addresses Thread-Index: AQHRycaWVqnZ4LB+UEiePUFXYRq64p/yg18AgAAOHYCAAAFjgIAABx8AgAD3VwA= Date: Tue, 21 Jun 2016 07:56:41 +0000 Message-ID: <1466495800.4742.1.camel@toradex.com> References: <1466298275-15753-1-git-send-email-marcel.ziswiler@toradex.com> <576810C2.1030401@wwwdotorg.org> <20160620164057.GD6175@ulmo.ba.sec> <57681DC3.9090801@wwwdotorg.org> <20160620171124.GA6333@ulmo.ba.sec> In-Reply-To: <20160620171124.GA6333@ulmo.ba.sec> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [46.140.72.82] x-ms-office365-filtering-correlation-id: 69e660a3-5c01-4d1e-d9ec-08d399a9954c x-microsoft-exchange-diagnostics: 1;HE1PR05MB1881;6:dWgt8xe3kwQDDPkUV3UsXpuB5drFGkYUcMAiX+OmJCfSfvcLliztTvD/UNipjgdl6iZUlArdv1NiVpFfmQ8Kp1rWZkSwq0aTJJLxsluKWytsmr3J1T+7icRiWtTxNwsgZArvsDd5J2INRPPNzEOx8bTRRn2Ql+O/IWCxI1X2Q3Kao+Sek2vsiAE8gIteuiYUS32fo6McalbQNym+2crC4tn3SfFrvFlSmGg/ZqWPkhj02a24UNo0AQ0/9NBSqMAnc9wSYx9HaUG+fm+Foh9Z6cg5m9QqfMRJSu6kvEQxjzE=;5:O7C0FXOs45GE+man0KHt5YiwBgIP7gDwJSN12mrv6A46eaQgJeypRG/nPD8QmItpesYQaTdHiSkeapWO7yuqUOT7pcIwxS2VEqD3NYlVj5ehEN7gIZ0/mhjSn8Tf0/AnZP0ITjBn1z81PNnrrgHAwA==;24:i9c0O/IjGrHHgzRi5KxYF7/9as1srcXNVcWPm/wyLKZRZiejUtYzXaBMP4eoJZVBQHTDYALJWvMUkgJZ4pFoCSwvkhL72PH0Ta4jH64HNqA=;7:Z+wDbsXqt8E8jZrkBDW7TxOCPXnBZ4V4jEdkBgTsQd1UHFumCw08d5mdU+W0KO8bh0Cj3JNqhW5/RkuvPzF/vnQx2eZcy5U3ZM8hUkn0WbfSiPYveMGQSQbmPMhAYg7bnw+Wbd9JSQjeeIFtJGGDj2c/rwdN5+Qi2bOx8uo1hwyzCqTiPjTW6DoO5Tu1/TL5Jc9Nt/+6rASURLIGg2+08CnzcKHy7A4Zvoy7K4tnVvKcpAc3uz+J//JPNTOPvj5c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1881; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:HE1PR05MB1881;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1881; x-forefront-prvs: 098076C36C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(377424004)(199003)(24454002)(189002)(377454003)(86362001)(15975445007)(5002640100001)(122556002)(77096005)(54356999)(2900100001)(189998001)(2950100001)(87936001)(8936002)(76176999)(50986999)(102836003)(2501003)(3660700001)(7736002)(68736007)(2906002)(3280700002)(4326007)(92566002)(5001770100001)(3846002)(97736004)(586003)(6116002)(10400500002)(106356001)(11100500001)(19580405001)(33646002)(81166006)(105586002)(101416001)(36756003)(81156014)(103116003)(106116001)(93886004)(19580395003)(66066001)(7846002)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1881;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <792C77FF8362D14FA983F57CB1E94295@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2016 07:56:41.7512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1881 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5L7w6w7031275 On Mon, 2016-06-20 at 19:11 +0200, Thierry Reding wrote: > On Mon, Jun 20, 2016 at 10:45:55AM -0600, Stephen Warren wrote: > > > > On 06/20/2016 10:40 AM, Thierry Reding wrote: > > > > > > On Mon, Jun 20, 2016 at 09:50:26AM -0600, Stephen Warren wrote: > > > > > > > > On 06/18/2016 07:04 PM, Marcel Ziswiler wrote: > > > > > > > > > > Remove commas from unit addresses as suggested by Rob Herring > > > > > upon me > > > > > posting initial Apalis TK1 support: > > > > > > > > > > http://article.gmane.org/gmane.linux.ports.tegra/26608 > > > > Acked-by: Stephen Warren > > > I'm confused now. I posted almost exactly the same patch a while > > > ago and > > > we agreed that we couldn't do this because the node names were to > > > be > > > considered part of the ABI. > > > > > > Is it or is it not? > > The particular case where it matters is the GPU node, which U-Boot > > manipulates. This revised patch version no longer renames the GPU > > node and > > so in practice avoids any issues that I'm aware of. > > > > If there's a more general rule that node names are part of the ABI, > > then > > indeed we shouldn't take this patch. > I'm somewhat uncomfortable with this notion. Just because we don't > know > of any other cases doesn't mean there aren't any. My understanding is > that it's fairly common to look up device tree nodes by name, however > brittle that may be. > > There's also the matter of consistency to consider here. I suspect > that > if we make this change somebody will notice the odd one out and send > patches to "fix it up". So if we get confirmation about this change > being okay, I'd request that a comment be added to the GPU node as to > why it is not converted. Sure, let me add such a comment in a v3 that it is crystal clear why we did so. > Thierry Thanks Thierry. Cheers Marcel