From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751997AbcFVNvb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 09:51:31 -0400
Received: from mx2.suse.de ([195.135.220.15]:52657 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751425AbcFVNva (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 09:51:30 -0400
Message-ID: <1466603223.16513.2.camel@suse.com>
Subject: Re: [PATCHv3 1/2] usb: USB Type-C connector class
From: Oliver Neukum <oneukum@suse.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date: Wed, 22 Jun 2016 15:47:03 +0200
In-Reply-To: <20160622114458.GF19856@kuha.fi.intel.com>
References: <1466520711-125758-1-git-send-email-heikki.krogerus@linux.intel.com>
	 <1466520711-125758-2-git-send-email-heikki.krogerus@linux.intel.com>
	 <1466540705.2014.11.camel@suse.com>
	 <20160622095016.GB19856@kuha.fi.intel.com>
	 <1466590495.12516.10.camel@suse.com>
	 <20160622114458.GF19856@kuha.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote:
> If our port is DRD (which would be DRP in the port controller spec),
> the supported_power_roles will list:
> 
>         device, host
> 
> And the power role, if the port is Source only, the
> supported_power_roles will list:
> 
>         source
> 
> If the port is Sink only, the supported_power_roles will list:
> 
>         sink
> 
> If our port is DRP, the supported_power_roles will list:
> 
>         source, sink
> 
> What is there that is missing? We are able to express all the types of
> "Roles Supported" that the DEVICE_CAPABILITIES define, no?

No, because these are distinct in time. Some ports are DRP so they
support

device, host

at the same time. Some ports can be switched between DFP and UFP
they then either support host or device. But you lose the information
that the ports can be switched.

	Regards
		Oliver