From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbcFWGpu (ORCPT ); Thu, 23 Jun 2016 02:45:50 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35125 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbcFWGps (ORCPT ); Thu, 23 Jun 2016 02:45:48 -0400 Message-ID: <1466664342.5839.39.camel@gmail.com> Subject: [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width From: Mike Galbraith To: Lv Zheng Cc: Bob Moore , "Rafael J. Wysocki" , LKML Date: Thu, 23 Jun 2016 08:45:42 +0200 In-Reply-To: <1466579229.3188.14.camel@gmail.com> References: <1466579229.3188.14.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 920de6ebfab8 apparently exposed a latent bug, doorbell.access_width is initialized to 64, but per Lv Zheng, it should be 4, and indeed, making that change does bring pcc-cpufreq back to life. Suggested-by: Lv Zheng Signed-off-by: Mike Galbraith --- drivers/cpufreq/pcc-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/cpufreq/pcc-cpufreq.c +++ b/drivers/cpufreq/pcc-cpufreq.c @@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void doorbell.space_id = reg_resource->space_id; doorbell.bit_width = reg_resource->bit_width; doorbell.bit_offset = reg_resource->bit_offset; - doorbell.access_width = 64; + doorbell.access_width = 4; doorbell.address = reg_resource->address; pr_debug("probe: doorbell: space_id is %d, bit_width is %d, "