From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750972AbcFWOGM (ORCPT ); Thu, 23 Jun 2016 10:06:12 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33271 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbcFWOGL (ORCPT ); Thu, 23 Jun 2016 10:06:11 -0400 Message-ID: <1466690767.4075.10.camel@gmail.com> Subject: Re: [RFC PATCH 08/11] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE From: Mike Galbraith To: Matt Fleming , Yuyang Du Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Date: Thu, 23 Jun 2016 16:06:07 +0200 In-Reply-To: <20160623130433.GF8415@codeblueprint.co.uk> References: <1466041775-4528-1-git-send-email-yuyang.du@intel.com> <1466041775-4528-9-git-send-email-yuyang.du@intel.com> <20160623130433.GF8415@codeblueprint.co.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-23 at 14:04 +0100, Matt Fleming wrote: > I'm curious - doesn't this break userspace ABI? These flags are > exported via procfs, so I would have assumed removing or changing the > value of any of these constants would be forbidden. Nope, if those change, you get to fix up your toys. Hopping in the way way back machine... @ -460,10 +460,11 @@ enum idle_type #define SD_LOAD_BALANCE 1 /* Do load balancing on this domain. */ #define SD_BALANCE_NEWIDLE 2 /* Balance when about to become idle */ #define SD_BALANCE_EXEC 4 /* Balance on exec */ -#define SD_WAKE_IDLE 8 /* Wake to idle CPU on task wakeup */ -#define SD_WAKE_AFFINE 16 /* Wake task to waking CPU */ -#define SD_WAKE_BALANCE 32 /* Perform balancing at task wakeup */ -#define SD_SHARE_CPUPOWER 64 /* Domain members share cpu power */ +#define SD_BALANCE_FORK 8 /* Balance on fork, clone */ +#define SD_WAKE_IDLE 16 /* Wake to idle CPU on task wakeup */ +#define SD_WAKE_AFFINE 32 /* Wake task to waking CPU */ +#define SD_WAKE_BALANCE 64 /* Perform balancing at task wakeup */ +#define SD_SHARE_CPUPOWER 128 /* Domain members share cpu power */