Re: [PATCH] powerpc/mm: update arch_{add,remove}_memory() for radix

Reza Arbab
2016-06-23T19:52:59Z

On Thu, Jun 23, 2016 at 02:37:39PM -0500, Reza Arbab wrote:
>Could it be that the functions just need to be renamed
>hash__create_mapping()/radix__create_mapping() and moved out of #ifdef
>SPARSEMEM_VMEMMAP?

Or vice-versa, maybe the callers should have been wrapped in the first
place:

arch_add_memory() {
...
if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP))
vmemmap_create_mapping()
...
}

arch_remove_memory() {
...
if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP))
vmemmap_remove_mapping()
...
}

--
Reza Arbab