From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752088AbcFWTGL (ORCPT ); Thu, 23 Jun 2016 15:06:11 -0400 Received: from smtprelay0006.hostedemail.com ([216.40.44.6]:60299 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751713AbcFWTGJ (ORCPT ); Thu, 23 Jun 2016 15:06:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:10004:10400:10848:11026:11232:11658:11783:11914:12114:12438:12517:12519:12740:13069:13255:13311:13357:13439:13894:14181:14659:14721:21080:30003:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: rain11_6f29b4b11a63c X-Filterd-Recvd-Size: 1928 Message-ID: <1466708400.1847.15.camel@perches.com> Subject: Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening From: Joe Perches To: Pablo Neira Ayuso Cc: Patrick McHardy , Jozsef Kadlecsik , Stephen Hemminger , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20160623173659.GA3474@salvia> References: <20160623173659.GA3474@salvia> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 23 Jun 2016 12:00:00 -0700 Mime-Version: 1.0 X-Mailer: Evolution 3.18.5.2-0ubuntu3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > There is code duplication of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > Applied, thanks. > > > > > Signed-off-by: Joe Perches > > --- > > > > This masked_ether_addr_equal function could go into etherdevice.h, > > but I don't see another use like it in kernel code.  Is there one? > This is specific of iptables, not even nftables would use this. So I > would keep this in the iptables tree. Did you see the other patch that adds a generic ether_addr_equal_masked() and uses it in a few more files?