From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbcFWTZH (ORCPT ); Thu, 23 Jun 2016 15:25:07 -0400 Received: from smtprelay0002.hostedemail.com ([216.40.44.2]:36117 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751547AbcFWTZF (ORCPT ); Thu, 23 Jun 2016 15:25:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:152:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3874:4321:5007:7974:8531:9010:10004:10400:10848:11026:11232:11658:11914:12043:12438:12517:12519:12663:12740:13069:13161:13229:13311:13357:13894:14181:14659:14721:21080:21325:21433:30054:30060:30083:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bird20_82e70020b363d X-Filterd-Recvd-Size: 1701 Message-ID: <1466709897.1847.24.camel@perches.com> Subject: Re: [PATCH] staging: wilc1000: arrays can't be NULL From: Joe Perches To: Luis de Bethencourt , linux-kernel@vger.kernel.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org Date: Thu, 23 Jun 2016 12:24:57 -0700 In-Reply-To: <1466704629-26084-1-git-send-email-luisbg@osg.samsung.com> References: <1466704629-26084-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote: > hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs > which have the following element: > u8 bssid[6]; [] > I am aware this patch gives a few checkpatch.pl warnings about lines being > over 80 characters. Fixing that would be a completely different issue, and > a lengthy one since the file has loads of them. > > Hopefully somebody else picks that up. Maybe I should send a hit to the > kernelnewbies mailing list :) Or not. really_long_identifiers™ makes using 80 columns silly. The hungarian could probably be converted though. A log of the memcpy and memcpy uses could probably be converted to ether_addr_ too.