From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751589AbcFXI3H (ORCPT ); Fri, 24 Jun 2016 04:29:07 -0400 Received: from mga03.intel.com ([134.134.136.65]:42756 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbcFXI3D (ORCPT ); Fri, 24 Jun 2016 04:29:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,518,1459839600"; d="scan'208";a="1008749491" Message-ID: <1466756938.30123.272.camel@linux.intel.com> Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set From: Andy Shevchenko To: Vladimir Zapolskiy , Lee Jones , Mika Westerberg Cc: linux-kernel@vger.kernel.org Date: Fri, 24 Jun 2016 11:28:58 +0300 In-Reply-To: <1466727074-14931-1-git-send-email-vladimir_zapolskiy@mentor.com> References: <1466727074-14931-1-git-send-email-vladimir_zapolskiy@mentor.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote: > If kernel build configuration has enabled CONFIG_PM and unset > CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not > be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro > declaration: > >   drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier > 'INTEL_LPSS_SLEEP_PM_OPS' >   drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’ > undeclared here (not in a function) And may I ask what ancient kernel you are using? commit 47b91923ea41288751e83a5b080576085a831333 Author: Andy Shevchenko Date:   Mon Sep 14 11:32:47 2015 +0300     mfd: intel-lpss: Fix build error when !CONFIG_PM_SLEEP > > Fixes: d35dbf0dbaa7 ("mfd: Add support for Intel Sunrisepoint LPSS > devices") > Signed-off-by: Vladimir Zapolskiy > --- >  drivers/mfd/intel-lpss.h | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h > index 764dc0d..0dcea9e 100644 > --- a/drivers/mfd/intel-lpss.h > +++ b/drivers/mfd/intel-lpss.h > @@ -44,6 +44,8 @@ int intel_lpss_resume(struct device *dev); >   .thaw = intel_lpss_resume, \ >   .poweroff = intel_lpss_suspend, \ >   .restore = intel_lpss_resume, > +#else > +#define INTEL_LPSS_SLEEP_PM_OPS >  #endif >   >  #define INTEL_LPSS_RUNTIME_PM_OPS \ -- Andy Shevchenko Intel Finland Oy