From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751465AbcFYHUs (ORCPT ); Sat, 25 Jun 2016 03:20:48 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38436 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbcFYHUo (ORCPT ); Sat, 25 Jun 2016 03:20:44 -0400 From: Matt Fleming To: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: "Compostella, Jeremy" , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Matt Fleming , Arnd Bergmann , Robert Elliott Subject: [PATCH 1/7] efibc: Report more information in the error messages Date: Sat, 25 Jun 2016 08:20:24 +0100 Message-Id: <1466839230-12781-2-git-send-email-matt@codeblueprint.co.uk> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1466839230-12781-1-git-send-email-matt@codeblueprint.co.uk> References: <1466839230-12781-1-git-send-email-matt@codeblueprint.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Compostella, Jeremy" Report the name of the EFI variable if the value size is too large or if efibc_set_variable() fails to allocate the struct efivar_entry object. If efibc_set_variable() fails because the value size is too large, it also reports the value size in the error message. Signed-off-by: Jeremy Compostella Reported-by: Robert Elliott Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Ard Biesheuvel Cc: Arnd Bergmann Signed-off-by: Matt Fleming --- drivers/firmware/efi/efibc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c index 8dd0c7085e59..568335d4239a 100644 --- a/drivers/firmware/efi/efibc.c +++ b/drivers/firmware/efi/efibc.c @@ -37,13 +37,15 @@ static int efibc_set_variable(const char *name, const char *value) size_t size = (strlen(value) + 1) * sizeof(efi_char16_t); if (size > sizeof(entry->var.Data)) { - pr_err("value is too large"); + pr_err("value is too large (%zu bytes) for %s EFI variable\n", + size, name); return -EINVAL; } entry = kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) { - pr_err("failed to allocate efivar entry"); + pr_err("failed to allocate efivar entry for %s EFI variable\n", + name); return -ENOMEM; } -- 2.7.3