From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752058AbcF0RZb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Jun 2016 13:25:31 -0400
Received: from mga09.intel.com ([134.134.136.24]:30277 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751749AbcF0RZ3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Jun 2016 13:25:29 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,537,1459839600"; 
   d="scan'208";a="836079390"
Message-ID: <1467048417.8970.80.camel@linux.intel.com>
Subject: Re: [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to
 some functions/variables
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jisheng Zhang <jszhang@marvell.com>, lenb@kernel.org, rjw@rjwysocki.net,
        viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 27 Jun 2016 10:26:57 -0700
In-Reply-To: <1467022038-924-3-git-send-email-jszhang@marvell.com>
References: <1467022038-924-1-git-send-email-jszhang@marvell.com>
	 <1467022038-924-3-git-send-email-jszhang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote:
> These functions/variables are not needed after booting, so mark them
> as __init or __initdata.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 44099e9..861bcba 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1355,7 +1355,7 @@ static const struct x86_cpu_id
> intel_pstate_cpu_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
>  
> -static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] = {
> +static const struct x86_cpu_id intel_pstate_cpu_oob_ids[]
> __initconst = {
>  	ICPU(0x56, core_params),
>  	{}
>  };
> @@ -1577,9 +1577,9 @@ static struct cpufreq_driver
> intel_pstate_driver = {
>  static int no_load __initdata;
>  static int no_hwp __initdata;
>  static int hwp_only __initdata;
> -static unsigned int force_load;
> +static unsigned int force_load __initdata;
>  
> -static int intel_pstate_msrs_not_valid(void)
> +static int __init intel_pstate_msrs_not_valid(void)
>  {
>  	if (!pstate_funcs.get_max() ||
>  	    !pstate_funcs.get_min() ||
> @@ -1589,7 +1589,7 @@ static int intel_pstate_msrs_not_valid(void)
>  	return 0;
>  }
>  
> -static void copy_pid_params(struct pstate_adjust_policy *policy)
> +static void __init copy_pid_params(struct pstate_adjust_policy
> *policy)
>  {
>  	pid_params.sample_rate_ms = policy->sample_rate_ms;
>  	pid_params.sample_rate_ns = pid_params.sample_rate_ms *
> NSEC_PER_MSEC;
> @@ -1600,7 +1600,7 @@ static void copy_pid_params(struct
> pstate_adjust_policy *policy)
>  	pid_params.setpoint = policy->setpoint;
>  }
>  
> -static void copy_cpu_funcs(struct pstate_funcs *funcs)
> +static void __init copy_cpu_funcs(struct pstate_funcs *funcs)
>  {
>  	pstate_funcs.get_max   = funcs->get_max;
>  	pstate_funcs.get_max_physical = funcs->get_max_physical;
> @@ -1615,7 +1615,7 @@ static void copy_cpu_funcs(struct pstate_funcs
> *funcs)
>  
>  #ifdef CONFIG_ACPI
>  
> -static bool intel_pstate_no_acpi_pss(void)
> +static bool __init intel_pstate_no_acpi_pss(void)
>  {
>  	int i;
>  
> @@ -1644,7 +1644,7 @@ static bool intel_pstate_no_acpi_pss(void)
>  	return true;
>  }
>  
> -static bool intel_pstate_has_acpi_ppc(void)
> +static bool __init intel_pstate_has_acpi_ppc(void)
>  {
>  	int i;
>  
> @@ -1672,7 +1672,7 @@ struct hw_vendor_info {
>  };
>  
>  /* Hardware vendor-specific info that has its own power management
> modes */
> -static struct hw_vendor_info vendor_info[] = {
> +static struct hw_vendor_info vendor_info[] __initdata = {
>  	{1, "HP    ", "ProLiant", PSS},
>  	{1, "ORACLE", "X4-2    ", PPC},
>  	{1, "ORACLE", "X4-2L   ", PPC},
> @@ -1691,7 +1691,7 @@ static struct hw_vendor_info vendor_info[] = {
>  	{0, "", ""},
>  };
>  
> -static bool intel_pstate_platform_pwr_mgmt_exists(void)
> +static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
>  {
>  	struct acpi_table_header hdr;
>  	struct hw_vendor_info *v_info;