From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcF1J7N (ORCPT ); Tue, 28 Jun 2016 05:59:13 -0400 Received: from mail-bl2on0078.outbound.protection.outlook.com ([65.55.169.78]:18678 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752156AbcF1J7K convert rfc822-to-8bit (ORCPT ); Tue, 28 Jun 2016 05:59:10 -0400 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; st.com; dkim=none (message not signed) header.d=none;st.com; dmarc=none action=none header.from=altera.com; Message-ID: <1467107935.2700.2.camel@ubuntu> Subject: Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga From: Tien Hock Loh To: David Miller CC: , , , , , , , , , , Date: Tue, 28 Jun 2016 02:58:55 -0700 In-Reply-To: <20160628.054815.1440008157228833144.davem@davemloft.net> References: <1466759603-30769-1-git-send-email-thloh@altera.com> <20160628.053450.2071467949973087029.davem@davemloft.net> <20160628.054815.1440008157228833144.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(24454002)(377424004)(199003)(189002)(2950100001)(6806005)(92566002)(19580405001)(305945005)(8936002)(19580395003)(33716001)(8676002)(189998001)(81156014)(33646002)(81166006)(47776003)(2906002)(8746002)(4326007)(7846002)(68736007)(76176999)(356003)(103116003)(86362001)(4001430100002)(97736004)(50226002)(106466001)(50986999)(50466002)(107886002)(5820100001)(42186005)(110136002)(105596002)(23676002)(9686002)(87936001)(586003)(7099028)(99106002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB292;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD021;1:sfyUT9FtIjO4rj5/Tt8H9ejzyVn11cJiIlhTzIHGNDWpHBuuBwqrb5Ss3KVvv0DTQe6QbJtRZ4TdK2ev1DWR5XM/u8AfSqK66qcHYjEgyZ5fGOZmvVahtUT4fiShb3lUyBraXAOIGJe2Jch/1MOESK5jliAkwEr7hOo3n+0mcjw2gL6ti0g7vjfxtIb7Tm4OvgXHQc/wB158PKNYRx9/WlhjirmEOeqrWerrHLG/09gdAWqKyfEjLno1cigL4WRKMItpOx/oAmrX2BqnN1Ccax+keYO0KtKpKTDVI4L72S3ncMbMty4M1ZCm7kvkf0ahCBS4vu8Xh3WhQ4K9ZlZ8Kf3bnpvoDNmfjPH5JwpzJ/bjvHig5QnrHd6mt+oDKluXF50Zf4aPlYDICvL4pCdQzTD0d3j2IaXDMdoeuAPnhux1+w4lgNOhVlIJQEfsvajUI7YMRGKvBGMtsTOPOw8wseAlBk4cE4tnTLIaB0dIRwB549nHHsLxjQanGIZtmteFdYOzvhDH5w1dRmNbUWg+24ZKQgLLux1gM3A3wo6Pew7gggS1cDdjOikPKGO4pdaELvqRjYdpSNFDMhVibakZxEkPFoM0twwV7LO+AAb9A1U= X-MS-Office365-Filtering-Correlation-Id: ada90c5a-9957-47ac-10e2-08d39f3ad83e X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB292;2:scaUsFFrlZ7XSqL6VO+froEUjMJnOd2DL5z5f2F8MLRIONumBklQtUH4vJxm29LOSokJdAlNweI8jjqihTlo+IGFg/c7Mojliv8eP40hemlt/5lBq5bGTTXgeDcV7PCBeHZZzAIl887RqH1HUmFrM20IwGfnCvJdxGVre0OAGyzSim2DqBldsSb4jmM6H9Lm;3:5PzcFSbT3QT3pGjTXg8wtrxZOKE7c8FnKDwGRr4ONLOKM9vGqAXEVPQEeHaLFjMrS+6MyzPscsHdmm5A59i9q7mH0RZP6mpO9/XfJ6da0DhLn2JUIMRc93sIPC5ugVySTnNT+KFdYlW+5vvhzshaounj1bC1RYeczqz+e+8K0TOuSsz0ldc5h6FmL1UwLA5OlZai/orrBjOlacDCd6albNdey5fLHUcU3mx1yRL+GiU=;25:smlDY6oy4IORtIvVQ0A3ov47Sa/ScoT4thgJYJ2XfGeIZkUaNgSK25IWjEXyI3hBi+r5gjqhFxTLE4+d6O25MqTWnVB1KjzeHqLwR6lLhrrahtzKYL8U8s8MJL4ggVC8iQstO0eImRqsAz0BUebtoZCIAMbRtm4icowSF5IHfFNUxUcz2MISSvgtqnFqSdSlL2eLc/pkvAW9DhMxhFyrPsEIX3y/5m5GHz84eo2vNeTOOCGJPRswgZE5dvbtl3YdVc3VQG7rLRH4JtsaVvgvTgPw7abBnV375ojgH3JZ4KgpGB2zlAsMK0ET2NdjthmxO0Gj9VP5i/039zlXKuO8ujWzRVGWOk3dyKRj0FyiI7wiDhmvyqlbU+CCyEkCsjamPgKcZ+eNibEU2UEfHgmKAMDZELfEPPuz/9mEtqpmVXc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB292; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB292;31:1BsaFT4MfQFT58l99FxVpvc0SEmO6xEmAk1+aZxyJFVboVDurTbykNrfgazy3FWJCTNoiBW/o7QOcPYfssmTe0jZxZUwv/yFQL24vFhKR7sZsKsUhYhnGB1PqZoG4d+Jub5mePTGQMmj1MNkz3/y7rssfYneH3CaxbWbzHG/c78mb1VCzzHOsw2c+8zdvkHaTp4JxPHOJtmu4ehxFupG6w==;20:xKzIvZ+HRisHHtmGExLEPauauS7D5ZTOJPFWunxs9UBClu+dOcMopjQcXFY6AntSE60HJBCGx82MJ5OU0p/9/8xSwzP6vWTriGPZX+01z5fu6CnkdAuE4jrYY2RBtIxq9codeA5BKCo9SgASkcXu5GvCCvv9D5kKV7aw5qXtqjI=;4:tQUwyn2sU1VmCDgGQserwx8Vak6armN626CfBtk4w1ijDEro1S134bGwel855fRESlB5pWWUrqyLIg49oujHtav1wDVy+WgCaIr4A+6Qck748ydg8lA7hDnO+Xc2Vnp8h7B/34M5XB1LpI/Jf8No/jtdsJvYnAbYvF9ooC0AbsfTc2fqo9wwFCEMtib7o72jSJLI5NfqEaQvGlMxCi/I1yjI8G1Y5SJUzJY3ZygJypjG11W2UmJj1xKOnVkwdRPOfgy6bRxUoNy+ckQSvcx0T7ZgjmHx0J6oM5kCmRKZlR7iiicQTRBvmlK7bWTBrDE6kGcd+oh4sB61U/MVn2dRB79xDFDjrH60iCBBTWDBKR3I6QvG3LSjEHNUQ0pU9vjAMwzsE5chWw8D7j9/8vaiaXOXzQhi7FoZP6CMe5CRlkN64blFC9J49nQn2CdHNHe1jhMaEFWluVvXEECk7D+dta6Nmh+mkuXnBTebAzB0aHGoyrPS6Wq67h2N/v/CD8plmfN3ZByv9ZByw5/Dm7KIWA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13017025)(8121501046)(13015025)(13024025)(13023025)(13018025)(3002001)(10201501046)(6055026);SRVR:BL2PR03MB292;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB292; X-Forefront-PRVS: 0987ACA2E2 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjAzTUIyOTI7MjM6ZW83MFdlS0NUcGhDUS85dUhaQ1QrWjNCU2lj?= =?utf-8?B?cWszUUQ3S21ENm0rdjl1dGt0RXJ4WEtRT0hmbmd6VW5sNWlOY1l4ajA1SWVk?= =?utf-8?B?ZTNvenhQcWVTaTN2bHhIMWhadGI2U0JXTmdXZ1JSalJITlg5US9YbmxMcVdQ?= =?utf-8?B?MlltNlBZV3A5dUVTVGMwamhtMVR1UGNvNlZSWFUvV0gzRkhmZGluVmQ2QXRy?= =?utf-8?B?SVkzUWt2VURTTHhiVkovMFZDTUFNS3VVb1NoTzZEenlHa1lvNjF6TGtpd3Fw?= =?utf-8?B?dFFPSTgyL25rb1YxWnJlOEh0QzhvUnVRcmN6UzlIMDJncStXZ1FBMWgzaHdj?= =?utf-8?B?VWVnVldGb0IvTEVFYTR6K1FoYkpJbnlGWXJZNWhmVGduZWsra3JCNGRaRlhh?= =?utf-8?B?REQvTW1MUVZrek1wM1lweXJuWG1NOFVNTTRoN1BBTCtpdnkzQW0vd21SSHJ1?= =?utf-8?B?RThwSUN2OXp0dzF6d3NpTmtCNkdSZVIwL1pnSVB5bTRwVEtvSG12R3NJZWtM?= =?utf-8?B?WVY2MFk4bk9vSkkwK0JMQWlSZlBueG1CcUltOUJHcGZ4eE41eEN1M3l1bUlm?= =?utf-8?B?YlZ0cHpNM1FNVkg5UFRvTWs5MEJNalVrNllPVTRxWkdVSXVkRlBIY0E2U1Bn?= =?utf-8?B?RG8vT2NpWjRhaEF4UEViYjVPSmdkdEZkRTN1UGp1S1VmRDNkWEwrbmRTQzBS?= =?utf-8?B?eG5Bams0bis1d1BmZHp0TlZSMVVyMHd0MmxuanM3RHNPdWFxV2llZnNsYjhV?= =?utf-8?B?TnVjZWpzTE85UDFZVW11YzgxNnA1dHdQUU1JQUVodEF0akgva05teVI0M3By?= =?utf-8?B?NDg1RjB0eHYrTWc4Q2xaZmlDbWdNc21lV3dkWHFHbC96NkhKa3hJVnZLM1JW?= =?utf-8?B?djM0MDhWNUlvbm5XSUdFYmgyUExWSUozQTRxdy8rRzl6L2gvdk5rU2U5WkIr?= =?utf-8?B?TnUzWWxiYVYxMUVDU1Z6Q2lKVFhXUTA5QWlUZmY1dDhmK1RPS1JtdWxjZDNr?= =?utf-8?B?dEdzVXlOa2I1N1NWbzQ5dUxoaGhReXA0blIvRG5sYzA0YnhiUGUrazR5L2gy?= =?utf-8?B?NkdMS0lOMlA3U0dEOTR2SkJidEc3UVBjT0p6RmtUc2ZTQ3UvVTRVbVZUMy9I?= =?utf-8?B?L0tORk9qbFlyQ3o2eGM0Z0JYbVNwRE1xMnZLbFdyOGpsdndKRldZU0FRMEhj?= =?utf-8?B?Mm5tRktpbXMzOUVnYXJ4cUNzRWFSMmR2c1hKRlZIQkdyYkRub0crT2NuSlJQ?= =?utf-8?B?M1BxVFF1dXFKWExoYUJDSlVUNzFJeHMvajNGaUd1WWppbExqeDlBV1ZzRVJM?= =?utf-8?B?RkdKT1VvYTdPVHZIcXJmZVdWVTJuUTB4aUEybzBCdDdyY0RHVzRlN2RxZURZ?= =?utf-8?B?Rjc2RVpBMTYyaDRYYUZrWjdaQjhPd1V2SzJPQ3NGb0J5VnI1TUI0Y0JGdmlN?= =?utf-8?B?NkpTYjFkOFdpV3kxOTNjUSszZ2lXM0lXZzV6YS9zQnBXVEdmMWhmcDVGVHVa?= =?utf-8?B?cXNBdC8rbktQWWllQlJ0V2NMNG9RekZ6QTl4bnl6WFlnM0szRGhhNm1YNWJs?= =?utf-8?B?R3AwQkxqcGI1bWtqcFBLZFF4SjJkdz09?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB292;6:HLqUYWbueBjTopxDQJ6oYgOFwH1TsPhzKRl67DGfFNDpDvGT/unloYKLs/xp9K26J+sNRh/wUQ8WhE2PeLkN3EX7VmPtnQkvxVj4+Z9DUOynUk2oKH3uYYLf0fhLzulbep1StenPvj7BcClngVGzIUpE569ym9yJrBnJm+81gpEzgD8OPdfwdhubmjeq7gbYt4+xY8LgNRXkPLfMa7vZLzqRN12QD+8PanD/tq0MdoAPSDX5om6/uM+WuRvjuFe5yq/l4wRSOYFyC1vthT6u4V2e3huHMS8xV03BsfrNdCdl/kHM6uvjSSP8XTz1hvsPh7CudTBwbhaKO7xMJop5zQ==;5:yUJ1RnVV8plna37lwwmqmTi8LyL7nbD8T49nv0ragQJiw1ZM9fXSAIzu7FXMK0PUYFnhhF6hXOYC7fpwx1kFg00Uu2ixqO5Kz/PZXojbc+59u70RQZllNXk+ubHfyJdF9K6C7jerPHr4H1rxoHU5qA==;24:+ABaq5wtBp7wFsn+WtwHsbPujD/ALFtzatw3vUfuAA7ZuDRW3vzy8koennZgqZaLUyWTJpfjCUuPTC09AhNvjHX9LGu1LeQYuK/mwhVqUak=;7:NMOaCn9BXYpQO3pREWSOp8f39iqRyUlJv7FdV6CCvMOcQAiiwHozjIbIxn48qoeBo/bxYyW/N2Vy3LouWNQL/rBgR7dPa/t+/TD0ZgLQ9P//V98CuIy+4aF+zU2CxDZ0tXNYLInJCmQnS5o/15H+jDb9yTmQHEDhSpPpwnMOr/YZwXNk6YQzTlhkOWH1b3NUizQJNSjxqOdT05P9BvBSiB6GXSTm9XuAN9l/ypopLEehlk4B6CCV3EZM1H+rW0BO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB292;20:qh1YOJB4jIpunysguJojKJ2Jei4na9y1NCXg6sQUsO2+61ROYfrAiQRE6/bj0w4sg2/fe4B3BQFo/q0hSxVt14ZQqPnPVQCQUXEiS5Xa8ajROGn/HJs8+XJJPaEbJS6LFuN2Rq82vKmHAOUKuvSmuimQosTi050gDeJtX2sFlZ8= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2016 09:59:07.0961 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB292 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My fault, I wasn't testing against building as module, was always building as part of the kernel. I'll get it fixed and put another patch for review. Thanks Tien Hock On Tue, 2016-06-28 at 05:48 -0400, David Miller wrote: > From: David Miller > Date: Tue, 28 Jun 2016 05:34:50 -0400 (EDT) > > > From: > > Date: Fri, 24 Jun 2016 02:13:23 -0700 > > > >> From: Tien Hock Loh > >> > >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > >> the dwmac is set to sgmii. > >> > >> Signed-off-by: Tien Hock Loh > >> Acked-by: Giuseppe Cavallaro > >> Acked-by: Rob Herring > > > > Applied to net-next, thanks. > > I had to revert, this breaks the build: > > ERROR: "tse_pcs_fix_mac_speed" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined! > ERROR: "tse_pcs_init" [drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.ko] undefined!