From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbcF1RE2 (ORCPT ); Tue, 28 Jun 2016 13:04:28 -0400 Received: from mail-bn1on0084.outbound.protection.outlook.com ([157.56.110.84]:2080 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752327AbcF1RE1 (ORCPT ); Tue, 28 Jun 2016 13:04:27 -0400 From: "Vesely, Jan" To: "bp@alien8.de" CC: "joro@8bytes.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Thread-Topic: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Thread-Index: AQHRs4wm2oGHldyw5E2eKYXo1jpFBZ/qkrr8gABjvwCAADJJgIAUKguA Date: Tue, 28 Jun 2016 16:48:54 +0000 Message-ID: <1467132531.2590.158.camel@amd.com> References: <1463854264-26445-1-git-send-email-jan.vesely@rutgers.edu> <1463854264-26445-2-git-send-email-jan.vesely@rutgers.edu> <1465487321.7114.0.camel@amd.com> <20160615115406.GF26566@8bytes.org> <1466013192.3265.74.camel@amd.com> <20160615205311.GB19822@pd.tnic> In-Reply-To: <20160615205311.GB19822@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jan.Vesely@amd.com; x-originating-ip: [165.230.225.50] x-ms-office365-filtering-correlation-id: 6f5ee30f-6200-4c77-b20c-08d39f74176d x-microsoft-exchange-diagnostics: 1;BLUPR12MB0466;20:NPAnQrFDT6OWsFx1npNoaRgf2olltVam+IhKxNA0Jg8djLTmFC/ETi2kwnMgtwPMWAOSOqPzNfNTjE+Wiw/PYhFDbzGKZ2/r4RuMc8Q0ywYb6hAOwGXY8FskypCgyb96Yz39gJSl5gPM5ggQkSOcAUfnpfvI98C0883SaHltvr1KFHnlRODYKI8k9nmyRQQetDGi9q+XEJP9gn80zZL5UyiGBlLz/dQV4cndoHtBauS8VsN6qO/zqXrCVMpwBQzq x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0466; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42068640409301); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BLUPR12MB0466;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0466; x-forefront-prvs: 0987ACA2E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(24454002)(69224002)(189002)(377424004)(199003)(106356001)(2906002)(105586002)(2501003)(36756003)(106116001)(122556002)(97736004)(1730700003)(8936002)(81156014)(54356999)(77096005)(189998001)(7736002)(76176999)(2351001)(19580395003)(5640700001)(92566002)(99286002)(7846002)(81166006)(101416001)(68736007)(93886004)(50986999)(5002640100001)(305945005)(8676002)(586003)(4326007)(15975445007)(103116003)(102836003)(66066001)(10400500002)(3846002)(6116002)(87936001)(3280700002)(33646002)(110136002)(86362001)(2900100001)(2950100001)(11100500001)(3660700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0466;H:BLUPR12MB0466.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <3C4D694E4E14434D913FCE474348F977@namprd12.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2016 16:48:54.4707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0466 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5SH4X6N014380 On Wed, 2016-06-15 at 22:53 +0200, Borislav Petkov wrote: > On Wed, Jun 15, 2016 at 05:53:15PM +0000, Vesely, Jan wrote: > > There are no specific bugs/oopses that these patches fix (that I'm > > aware of). Both were found while I was familiarizing myself with > > the > > code looking for memory corruption (which turned out to be [0]). > > Either issue would be very difficult to hit in the wild and > > mutex_destroy is empty unless you compile using > > CONFIG_DEBUG_MUTEXES. > > See Documentation/SubmittingPatches which explains what "Fixes:" > means. > > That same file also contains info in section 2) how to write commit > messages. > > Please read it, it'll help you significantly if you're planning on > sending more patches to LKML. Hi, thanks for all the hints. I'll try to revisit and update the patches soon (might take few weeks though). Kernel development is not my (current) job and other subsystems don't have these requirements, if submissions need more than just git send-email of existing fixes dedicating extra time is difficult. Jan > > > [0] https://lkml.org/lkml/2016/3/7/1087 > > Oh, and also, please don't use any web pages archiving lkml as > pointers > but the kernel.org redirector: > > http://lkml.kernel.org/r/; > > or > > http://lkml.kernel.org/g/; > > (that second one redirects to gmane) > > HTH. >