From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbcF1ToE (ORCPT ); Tue, 28 Jun 2016 15:44:04 -0400 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:53672 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752357AbcF1ToC (ORCPT ); Tue, 28 Jun 2016 15:44:02 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3874:4321:4362:5007:6120:8660:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12296:12517:12519:12740:13069:13148:13230:13311:13357:13439:13894:14659:14721:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: stew27_5aae26dd0011 X-Filterd-Recvd-Size: 1870 Message-ID: <1467143038.24287.50.camel@perches.com> Subject: Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints From: Joe Perches To: Jon Mason , zajec5@gmail.com Cc: davem@davemloft.net, f.fainelli@gmail.com, hauke@hauke-m.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 28 Jun 2016 12:43:58 -0700 In-Reply-To: <1467142484-11161-2-git-send-email-jon.mason@broadcom.com> References: <1467142484-11161-1-git-send-email-jon.mason@broadcom.com> <1467142484-11161-2-git-send-email-jon.mason@broadcom.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote: > The bgmac_* print wrappers call dev_* prints with the dev pointer from > the bcma core.  In anticipation of removing the bcma requirement for > this driver, these must be changed to not reference that struct.  So, > simply change all of the bgmac_* prints to their dev_* counterparts.  In > some cases netdev_* prints are more appropriate, so change those as > well. Thanks, but... > diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c [] > @@ -1515,7 +1516,7 @@ static void bgmac_get_drvinfo(struct net_device *net_dev, >         struct ethtool_drvinfo *info) >  { >   strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); > - strlcpy(info->bus_info, "BCMA", sizeof(info->bus_info)); > + strlcpy(info->bus_info, "AXI", sizeof(info->bus_info)); >  } Unrelated change?