From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932108AbcF3Jiq (ORCPT ); Thu, 30 Jun 2016 05:38:46 -0400 Received: from mga14.intel.com ([192.55.52.115]:40453 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbcF3Jim (ORCPT ); Thu, 30 Jun 2016 05:38:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,551,1459839600"; d="scan'208";a="1012654571" Message-ID: <1467279517.30123.346.camel@linux.intel.com> Subject: Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc From: Andy Shevchenko To: Kefeng Wang , Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, z.liuxinliang@hisilicon.com, guohanjun@huawei.com, linux-acpi@vger.kernel.org, xuwei5@hisilicon.com, graeme.gregory@linaro.org Date: Thu, 30 Jun 2016 12:38:37 +0300 In-Reply-To: <1467250062-61583-3-git-send-email-wangkefeng.wang@huawei.com> References: <1467250062-61583-1-git-send-email-wangkefeng.wang@huawei.com> <1467250062-61583-3-git-send-email-wangkefeng.wang@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > that it is not 16550 compatibal. > > Meanwhile, set dw8250_serial_out32 to keep consistent between > serial_out > and serial_in in ACPI. > > Signed-off-by: Kefeng Wang > --- >  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- >  1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index 65f3da7..096431b 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan > *chan, void *param) >   return param == chan->device->dev->parent; >  } >   > +/* non 16550 compatible id list*/ > +static const struct acpi_device_id non_16550_id_list[] = { > + { "HISI0031", 0 }, > + { }, > +}; > + On first glance it looks redundant, see below. >  static void dw8250_quirks(struct uart_port *p, struct dw8250_data > *data) >  { >   if (p->dev->of_node) { > @@ -301,8 +307,10 @@ static void dw8250_quirks(struct uart_port *p, > struct dw8250_data *data) >   p->iotype = UPIO_MEM32; >   p->regshift = 2; >   p->serial_in = dw8250_serial_in32; > - /* So far none of there implement the Busy > Functionality */ > - data->uart_16550_compatible = true; > + p->serial_out = dw8250_serial_out32; > + > + if (!acpi_match_device(non_16550_id_list, p->dev)) > + data->uart_16550_compatible = true; >   } >   >   /* Platforms with iDMA */ > @@ -618,6 +626,7 @@ static const struct acpi_device_id > dw8250_acpi_match[] = { >   { "APMC0D08", 0}, >   { "AMD0020", 0 }, >   { "AMDI0020", 0 }, > + { "HISI0031", 0 }, So, we may put something instead of 0 here and consider it as a set of special quirks / setup instructions / etc. struct dw8250_dev_info {   unsigned int  uart_16550_compatible:1; }; static const struct dw8250_dev_info hisi_dev_info = {   .uart_16550_compatible = 1, } ...  { "HISI0031", (kernel_ulong_t)&hisi_dev_info }, ... And so on. >   { }, >  }; >  MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match); -- Andy Shevchenko Intel Finland Oy