From: "Pranay Kr. Srivastava" <pranjas@gmail.com>
To: mpa@pengutronix.de, nbd-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: "Pranay Kr. Srivastava" <pranaykumar.srivastava@cognizant.com>,
"Pranay Kr . Srivastava" <pranjas@gmail.com>
Subject: [PATCH v4 1/5]nbd: cleanup nbd_set_socket
Date: Thu, 30 Jun 2016 14:02:01 +0300 [thread overview]
Message-ID: <1467284524-15676-2-git-send-email-pranjas@gmail.com> (raw)
In-Reply-To: <1467284524-15676-1-git-send-email-pranjas@gmail.com>
From: "Pranay Kr. Srivastava" <pranaykumar.srivastava@cognizant.com>
This patch
1) uses spin_lock instead of irq version.
2) removes the goto statement in case a socket
is already assigned with simple if-else statement.
Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com>
---
drivers/block/nbd.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 56f7f5d..766c401 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -643,17 +643,12 @@ static int nbd_set_socket(struct nbd_device *nbd, struct socket *sock)
{
int ret = 0;
- spin_lock_irq(&nbd->sock_lock);
-
- if (nbd->sock) {
+ spin_lock(&nbd->sock_lock);
+ if (nbd->sock)
ret = -EBUSY;
- goto out;
- }
-
- nbd->sock = sock;
-
-out:
- spin_unlock_irq(&nbd->sock_lock);
+ else
+ nbd->sock = sock;
+ spin_unlock(&nbd->sock_lock);
return ret;
}
--
1.9.1
next prev parent reply other threads:[~2016-06-30 11:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 11:02 [PATCH v4 0/4] nbd: nbd fixes Pranay Kr. Srivastava
2016-06-30 11:02 ` Pranay Kr. Srivastava [this message]
2016-07-07 14:56 ` [PATCH v4 1/5]nbd: cleanup nbd_set_socket Pranay Srivastava
2016-07-09 7:36 ` Pranay Srivastava
2016-06-30 11:02 ` [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown Pranay Kr. Srivastava
2016-07-04 7:06 ` Pranay Srivastava
2016-07-10 12:25 ` Markus Pargmann
[not found] ` <CA+aCy1GZo6Vk9Yy1KXWgyVhcGmVETyuPuhQT=pSVDVxi5qr8ww@mail.gmail.com>
2016-07-13 7:13 ` Markus Pargmann
2016-07-14 5:59 ` Pranay Srivastava
2016-07-16 9:22 ` Pranay Kr Srivastava
2016-07-16 9:22 ` [PATCH v5 2/4] nbd: fix might_sleep warning on socket shutdown Pranay Kr Srivastava
2016-07-16 10:14 ` Pranay Srivastava
2016-06-30 11:02 ` [PATCH v4 3/5]nbd: make nbd device wait for its users Pranay Kr. Srivastava
2016-07-10 13:02 ` Markus Pargmann
2016-07-10 16:02 ` Pranay Srivastava
2016-07-13 7:54 ` Markus Pargmann
2016-07-14 5:47 ` Pranay Srivastava
2016-07-16 10:36 ` [PATCH v5 3/4] " Pranay Kr Srivastava
2016-07-16 10:42 ` Pranay Srivastava
2016-07-20 7:47 ` Markus Pargmann
2016-06-30 11:02 ` [PATCH v4 4/5]nbd: use i_size_write to assign nbd device size Pranay Kr. Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467284524-15676-2-git-send-email-pranjas@gmail.com \
--to=pranjas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
--cc=pranaykumar.srivastava@cognizant.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).