From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbcGAKD7 (ORCPT ); Fri, 1 Jul 2016 06:03:59 -0400 Received: from mail-sn1nam02on0068.outbound.protection.outlook.com ([104.47.36.68]:21152 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752616AbcGAKDx (ORCPT ); Fri, 1 Jul 2016 06:03:53 -0400 X-Greylist: delayed 887 seconds by postgrey-1.27 at vger.kernel.org; Fri, 01 Jul 2016 06:03:53 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=fail action=none header.from=nxp.com; From: Peter Chen To: , , , , CC: Peter Chen , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , "Krzysztof Kozlowski" Subject: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle Date: Fri, 1 Jul 2016 17:42:01 +0800 Message-ID: <1467366121-14120-8-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467366121-14120-1-git-send-email-peter.chen@nxp.com> References: <1467366121-14120-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131118401621469882;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(105606002)(87936001)(8666005)(575784001)(86362001)(97736004)(5001770100001)(2201001)(81166006)(81156014)(8676002)(305945005)(68736007)(229853001)(2906002)(36756003)(4326007)(586003)(106466001)(2950100001)(50986999)(104016004)(19580395003)(76176999)(69596002)(11100500001)(19580405001)(92566002)(33646002)(48376002)(189998001)(7846002)(50466002)(5003940100001)(47776003)(77096005)(85426001)(6806005)(356003)(50226002)(8936002)(7059030)(2101003)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0301MB0854;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD015;1:L+yjJm8S8gHL1+BWs54Vo9Ab8BJZ57FUUm2Hvo01JIiw1LbFu6PcTmD1gQTfNbjq+DBWUgLaFM41brj/GVNcMyKmYSRw85sbi+uZDKmejLaeupvIlcfB3ONjB3wCkAk7Zz7ak1UmU0e7+5nXfagLRNBXgNkxDsU7q2eVwqof4NDEVI8RNKY/KG/g+wOupL0ILCTbKWnXEPbMgb7CEXt7DI++0NfUXsybDYlet1/5dqa9heWVQjerHbFiX5bYyKqI0Tj7gAUIMQaOvUKxLaqZ4SoU172Gd6EW8gFa5R30E+yFNCLhLyYFrRu+X+XgNSLrlO4YFIMTYm/a8pCrkAs5RQCzilGNq7dzgHTukl0h60zN7E2+AV+ACsZv3pRXMWPZUgmzT0Bl2wrOrbKfesY1ddvf1a5J8Cz8cX37EapNgtZLWaibqFWzcGB4HaOKlUb1kHN8+MmS76W7mmt1tKsqtfot9AnJgae4r1CF91X5T9ScdX9Vs/elTE9659m2ruw1tzvsGqtE4Ej4k4v3F276lCwoaKbn4PizyM2/PW//Jgg8S9X3mvIiUlKNYlKm+MyBSXVPnTs/fL6MFiW1iq5uKLAjFsQNT85Wpf/vPAKtBuO4Ql0TwZORqUM2coc2wsP2 MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 5b40407f-8007-4882-c959-08d3a194fa9e X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0854;2:0S8UfU4bF6odWQAPLw5b9Y7MsdQXfcj+GAMm6eZeMEfYEspLo3sKbYF/gn6bbrRnfk43qHTHwnFVqWmnYBzIGvrMv1uHI0nFXMtjbTJmuMuqoj4fLGqLRPULKzIYmCFkURWNezQVPBZfAWO/vN9A9na7lvALTGHN9hXxzl0TFpMwXpFsSyR99wia+SduvYhq;3:ODQCIJr/zfmTg3HCLaLe+xgzi30q0HMXansSvtFnVoYPbdiB+q5B1IB9wlnguXvS+W1Pnj68DaWwLVkY5bmsAn9Nv0y3u2uv3smlfkwpOwDl0zGqPAAveSqqfi8IC+iD84aR3fCAN+fo6v9FoTU8RcO7V3mS60tMM8fjHN6NKMjYhMSofDrGw3CpgD+9ip6TzXO5jt5d0m7oz94byhK97J+LnsshsSZTOyNDviWNgy0=;25:eqQUPwqc8foS/jJAz1WeeOcBfasonhGq2WNQHxqrW7gjsMRnuUKwzcYrpa+CmpCFUaU5BXHwJ4Xw/DzbxmPM8APem9jaGwla+hACgUYc/r2L9jxSlOE8Ya3kLuoMFVIfvtkB80IcNcWCfchsE137cAWSmNGWWC7hXVFu6WL//0SvD3Fwj1RKX1De4R2M5iAbcFfJL0nuO2oAzscAgnizlWSzdYaG/ia4iaEWscEcelyYmf7TMYV4NIt2/CP/FCx5GmB3188dHktehCy2Ct/BQgvggSRI/jOjE+RpYq+T8w/WNYv9fLxp4Z8VrJ2pAhkyWQfuEnxjsff0/GLaLq+fxkIDg5/6bFs3FPr26wb1XHqXLeL5wjYVgnj7pBK9k3p1UfgQJ2ihfMWBZmMf+GmBj08Bp6aGmOXsrScpJo5V/ok= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB0854; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0854;31:7EAjXtktKU/rM06dOmlbE3lPx/YmxxUi/MVB45oECChbBoRP/D32JEkHDUh1TboGXyxCmWivkhHvS1GYZ2sjj6Wwk6lAZdKQTT7J21nbPN487MnaF9O1uit5B6lWOLCB8vgfAbfefktfLXgttJM4E/7x7y+9AC/ROwXwRkKuNGMh5Lq7JXUwBcTA4agZFuRh5g7ICb5ynb6jOo8E6i2YJw==;4:ljHASShyTbqNb6YaHkegHtVRpxXTlRGXFXiCFd91Z+lVxbP+IoR2OARoWO1VIcdr4Zq0um5lPp1O7NFIIrR0DiNm6W8ML+ZFpXP9KOHXEEUYNPjMY/B42TLWZr5PD/kKCmxpt657xl+hPCxCJedgSGHbYTsnVdY2JjEqmkN+6KqE5qisvV/w8UfPk6FaUDrDQBeTV8MfTTrgKUIyK9i+a2r7tSBKmse9/tJLY1vpWbCsI6wpqcG7lA83k/XlAZXDzcsz0fDfLa91hkuohlP1BmjSYQxCLB7KGoiEYj3wKYx0Pt8KNU9EBms5n4dym9JmjFe7arMYrsCz5odKLJ82nqytB1yL90EFJ5V+yINjIaxAB58DjuOMd+Ay3AFCCzYhxk0sAQhsR/+zuPS31uIV4Y+Aa60NokFqdgwnL9LJQewtXTqL9QJ/BKBUMzNg3mw5Wh0ktE+GZ3uVidgvVItta2Z7Otr0r8YUd2g5NFdRX5v4zfR92KvH8r1e68FZG787tl1wa69huru1x2DzQdvoisi3ixKZlaqDFpSr5/miJHDDmjFAxhmCxKs92I+eOW9s X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(7411616537696); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(13015025)(13018025)(13024025)(13023025)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BY1PR0301MB0854;BCL:0;PCL:0;RULEID:(400006);SRVR:BY1PR0301MB0854; X-Forefront-PRVS: 0990C54589 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0301MB0854;23:zV8bPRB4j6i9LCWl2fTqjlBxSZM2DwNoi+8FmR6?= =?us-ascii?Q?fb1pHE9Vcrw4TrpRg3reKlEa5E/Uz4bo6ExXDcD7DylRzQGryCj7O71KPkTM?= =?us-ascii?Q?vIALdxachEY11Xt9mFggewgPADS2jh7ILtAnZl7R1nvXo9XnKo652ZTUPstf?= =?us-ascii?Q?whSQ8MQn72vMGmh/nxrZ4uFyOYIoV2dp4Awq5/kytfjNw7iDhCviMEfjY/TL?= =?us-ascii?Q?kBIC5rV5e4CJOVT7gnV1TmOE0d5y2ANSvFqITJmNyU8WsJU1nXD7iQFVXNBI?= =?us-ascii?Q?cmfSMvZnXf6WOCTq+4BBQ9QxGqxz2V64PfOPpU3f7YfMLdmQJ+u+vTN872oG?= =?us-ascii?Q?3UtC6pgWwEBSXr58uARJ0T7FgkSmFeq0ODj7KGuMMITizcdZZvxaQfVT3X4+?= =?us-ascii?Q?+M4rhsMskEW/vEdxOB8MUoJis0j53URyp2uYxLwDztHys+1CAqeM6PDLtrYW?= =?us-ascii?Q?ojsVQJvadL7YoN4JGpq9xaQDXSH2DgGkNx3332yQBo5KaXpyTrPG/k2GHglg?= =?us-ascii?Q?ZvFEvCZKlAtVluAKPRPV4h4Hug7q/tZz4lId19NLD2QCjrYg6vpWk1mLLAyi?= =?us-ascii?Q?Ua+ns/eNhgQj9/xN2P6B9pnpxOp/mfQexQTXIcJPVtPb5Z9DXXXoQGxvC59I?= =?us-ascii?Q?ck1FU96ohq+KzGsa3z5YDCrLRQ9ubzp6QWF068N+eMlilXZsmY2o0AIBW4qT?= =?us-ascii?Q?T5xilGbaUewciKQSMKblHzL+o/V3gcX1+9n+Z2Lv//lgwUuU6g/A/jKOUm6M?= =?us-ascii?Q?rfozdTSLDrFpAl+GS2jZWot7/7vqDYGho9Isr4j1aS5++gqpnjcasmSTJoQU?= =?us-ascii?Q?ZcEL2f+PBaP98fiLLRWyyQfYYQJvLvx3SJKZcbEqTNUTL86A0wpm5yQcS507?= =?us-ascii?Q?86VmJ1japUmfd6SZGqNI7ddjqd6fKQPhbIXC1XkbEVOe5Md5BVhwDa5CgmCA?= =?us-ascii?Q?L5RSIqP6kjjM466vOcmb4Aa16XU8A42MNS18rQx5qkVvP2/pBJBFkzM8IH7s?= =?us-ascii?Q?j8hHuQylCH2wGWVvH082VyAhy9LiZ4YBZzrR+oUS8AF6Pae7KlpBoSw3TzRo?= =?us-ascii?Q?WySJ1lhsl+1TfujIlhrL24q12w3zIYIBs7MGSVvqKHtpCYePN8fuuccaujWN?= =?us-ascii?Q?qBDOcju6VRb0FwwWbauj/YCupyp/IUqGeGCeMuWJekExUN4+3HIuutqObY8R?= =?us-ascii?Q?dsufq+GmbA1XSCTL9cK8G/zSNNEw8oEwxRLdGoYLXI7pkysTcwLEdFnoCvPH?= =?us-ascii?Q?jCljtY6wFdFPXM1aV0eP2ISa6wJ8Gj5DfquuYyjqrP2M6B4kc/N7HGpHrsy5?= =?us-ascii?Q?7ZP/YSFR6RFUDeoWDMyZFGMU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0854;6:Cc9ccBKu8hd222TvFzwGBRTDpNtkpLbA8RsSzLsP1B322o1vXAmkGNz/+rQopEgxFmj4mCLGKP8PeGIpgjdo2bcCuWkIVFTmkXqSNqCFbR6CxbExw60o+Wb8axETCkTnLoRobStjLKpdyW93UWsgBZfOSOyAeEUtIu8cC0hIuS3ya57Vg15QUrb7/LBhzOLKAFEcnLzBW6RwMnSDd2AtLOeO4r/1cQArL+4YBMkKLNWBPhYlgrGDUOpuiv1gXoiA6UuZ5o3bVOV6tHjcgex9TJdwHZEAbnKBrTvea/H1w/4=;5:5rVv8Lvs9625N/y8lBfC+EjPJaCxozWcXzFvkEiqSMYwRXZNjQoDI+UUUUowYvWCCmbEUtuW99Ckh/2p6X/p1N7JcmU/yXjFnXKtcNLzeFSavGdK6ZKS77EjwJ5tN9kYPbQWqSnltZVLVmPxUCNmRKy51dSCHrlRVy5ImUq17aI=;24:s5kQKVn6RLuCrJV3U2sbiZrVx7Y8OXhFqBuxEQsco5oU9Qj5ehlQR9ebswYhZaG+nqFRkGtHYTvc16tTnWVXQxUGVf9/BO7KXAGXOfRgrdA=;7:yvdCI0Odxqzz1tBbrP3ASVmRagrCFv11AbvgQzfpVoHcTjsK06HlLlz3N8YUCjTBWXDiTEZOT0a6JIyyRw8uRbbzqRcKQipk1VldbV7aIw2ilMWLfM7weiEyJ+GcdSzR9MPm1Qocv33E+UMdWtLp55e8HP1fq1CQMybO+SbsXCbrAmxpHAOu6oKTj7NMvlitTf+4hCn9QYE/yOIfwPq3n2T8JW+2OWyuvOCZaXWQsBshX4rV3TQQk8x5v/PySpeX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2016 09:49:21.7881 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB0854 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Chanwoo Choi Cc: MyungJoo Ham Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Signed-off-by: Peter Chen --- drivers/devfreq/exynos-bus.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 2363d0a..a38b5ec 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -383,7 +383,7 @@ err_clk: static int exynos_bus_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *np = dev->of_node; + struct device_node *np = dev->of_node, node; struct devfreq_dev_profile *profile; struct devfreq_simple_ondemand_data *ondemand_data; struct devfreq_passive_data *passive_data; @@ -415,10 +415,13 @@ static int exynos_bus_probe(struct platform_device *pdev) goto err; } - if (of_parse_phandle(dev->of_node, "devfreq", 0)) + node = of_parse_phandle(dev->of_node, "devfreq", 0); + if (node) { + of_node_put(node); goto passive; - else + } else { ret = exynos_bus_parent_parse_of(np, bus); + } if (ret < 0) goto err; -- 1.9.1