linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ACPI/init: Correct the comments about acpi_subsystem_init
@ 2016-07-04  3:13 Baoquan He
  2016-07-06 21:32 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Baoquan He @ 2016-07-04  3:13 UTC (permalink / raw)
  To: rjw, lenb; +Cc: linux-acpi, linux-kernel, Baoquan He

In acpi_subsystem_init, function acpi_enable_subsystem is called to do
the real job. However with different flags passed to acpi_enable_subsystem,
different code is executed. In acpi_subsystem_init with "~ACPI_NO_ACPI_ENABLE"
passed in it will only switch over the platform to the ACPI mode. The rest
part of acpi_enable_subsystem is done when acpi_bus_init is called.

So the comments above acpi_subsystem_init is not exact, change it here.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 drivers/acpi/bus.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 262ca31..eef468d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -961,8 +961,7 @@ void __init acpi_early_init(void)
 /**
  * acpi_subsystem_init - Finalize the early initialization of ACPI.
  *
- * Switch over the platform to the ACPI mode (if possible), initialize the
- * handling of ACPI events, install the interrupt and global lock handlers.
+ * Switch over the platform to the ACPI mode (if possible).
  *
  * Doing this too early is generally unsafe, but at the same time it needs to be
  * done before all things that really depend on ACPI.  The right spot appears to
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI/init: Correct the comments about acpi_subsystem_init
  2016-07-04  3:13 [PATCH] ACPI/init: Correct the comments about acpi_subsystem_init Baoquan He
@ 2016-07-06 21:32 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-07-06 21:32 UTC (permalink / raw)
  To: Baoquan He; +Cc: lenb, linux-acpi, linux-kernel

On Monday, July 04, 2016 11:13:59 AM Baoquan He wrote:
> In acpi_subsystem_init, function acpi_enable_subsystem is called to do
> the real job. However with different flags passed to acpi_enable_subsystem,
> different code is executed. In acpi_subsystem_init with "~ACPI_NO_ACPI_ENABLE"
> passed in it will only switch over the platform to the ACPI mode. The rest
> part of acpi_enable_subsystem is done when acpi_bus_init is called.
> 
> So the comments above acpi_subsystem_init is not exact, change it here.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-06 21:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04  3:13 [PATCH] ACPI/init: Correct the comments about acpi_subsystem_init Baoquan He
2016-07-06 21:32 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).