From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932187AbcGDHDS (ORCPT ); Mon, 4 Jul 2016 03:03:18 -0400 Received: from mail-sn1nam01on0045.outbound.protection.outlook.com ([104.47.32.45]:8374 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750928AbcGDHDP (ORCPT ); Mon, 4 Jul 2016 03:03:15 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;nxp.com; dkim=none (message not signed) header.d=none; From: Peter Chen To: CC: , , Peter Chen Subject: [PATCH 1/1] firmware: arm_scpi: add missing of_node_put after calling of_parse_phandle Date: Mon, 4 Jul 2016 14:55:57 +0800 Message-ID: <1467615357-440-1-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131120893873742394;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(87936001)(11100500001)(50466002)(305945005)(68736007)(50226002)(8666005)(7846002)(48376002)(8936002)(86362001)(104016004)(106466001)(85426001)(33646002)(6806005)(19580405001)(8676002)(69596002)(47776003)(81156014)(97736004)(229853001)(4326007)(586003)(2906002)(2351001)(189998001)(356003)(105606002)(92566002)(77096005)(50986999)(110136002)(5003940100001)(36756003)(81166006)(19580395003)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB243;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD010;1:v3G75uQ8yuH/iZi1Z507jGR17RBusgs6jPo2sLRTes0eMc2Vp31xHAMMj30BI9pwZ5GvEgOla2fYYSXGEWVZXU4KJ3AOastB+Uxbk8UpL53cofJfAwo6xCTWdPtgcdI5gEQM7QgaY1ysZaXx7L4kjLrOFtuupbQ6bgUPe2+xmKAYEy4rkYDngADGYnC1CTqht356pC1Ad1jrNNIhG2vvEuOPC51z4FldUkHa37p7bY1cd49O6KFl6v2BdAMhF6Llwk0rh+FJngIpyG5UhkqD4eZHC0PSdmhD0ecqVgiQnpyuyMf3mvyLykzkg5ImQTjG/9wuHR0kMJo8N9pguk/YimeOwwTXQK10U/8gtg+UeyoMxfp29i6j+JHgWSU9wzk1rpLEi0HrKWTXrAMM4/MbqXIHtwy4ZvneU+DZo+CEBBQzPuw1Ro3dybxAj9u6WFNRPfSU8RxmVnwz9wMshS7roWo/NQoroYggUjvCHDpZ10XDBaU0LV1BxTIsUrq1LoCf2ToWKGWtFdGQZlLUGLm5/bIQOVAahmUjYKHsecSp1jrW7Fu+U3bMzJtS41rqTiFu4u2w8AfHhgS4Gkf7+pEdhV3gBnjIUONBLOlhPWnj8DHU1GykeL+6csqTeJGnCxZ7LUOMuTSnYHSDweYN32DXZSBubZ0t63VDFlFA+xYtddwhRtnb/jDjLgv5LhXqHPE9pw8oV58h0Med0DP1ZcDMl52Ras/2XR2/Ivz9b8NnxI1yzwQJgQ86bvH+weEXaQWu MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 97d98f2d-788f-4d44-d73a-08d3a3d9405d X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB243;2:6jiWZQsgUZxsDE9MZ7QLEsvfCyMnjkstzoKTDGczYuBm/F4S1sAOEaDZZaIaFdO8biRiQSL40YaaR1sKXcyB2XkPUT3qW4jZv/oJNW7HMWqilMX4tjLYdPi7h8LxGSEnQ4/JFlvYQyZx/joix6BZuOPQv7JI8qiInYwmkhQPYyADR1rOoNvIyZWtSkDOyBXR;3:CMzXa1RBfmeMbBlrt1lhd5eaBTNbMjehe2nTe3QOamdwiYciQjJH1UrJBxfeC0tH2NCTifzCeXA20L0hCcL6ms3+X8EgvllNdrhAjOA5kxQJQodIDQsBsEJ3ROAvmV7AxwZGSeHVplRWz9atZmVQ/IU7fT0mNKoREH320TXkMGd9VCtXtFSSnvejUjA2jWeVk6Gg3ZiwevDKsH2mVJ0O+hxh2IUoiJsKEjn7Ahd0S+s=;25:j9sO4MH1UbSvK30KJo6ge3BnFaqFyVgw1WvbOFyCV+eQk3KFZY9YZPW03hAswWpFjlFqwwqjgGUpKhJODuuZkiwn643YHykDX28T+GJdkrGS1hyexu5h04Acl9aDPn+aoDgN0EH6hBj9QKb4OkADi7HM0G+nl+ktIfQv0vkF3yr9H0HKXW8w2Js4egF/VtohfQT96v0W1R/h7JQWK25Ba8BiksoVxIrXNYTm/hFWOxuweCFXFy6megrWzcaNDfYHlm6s7JyOeGRQIfeUwqTzWxy6kULkx3wSw14lbj3OJVL0cbFqHJD6PAdS8aW8agCNoRNmuOk1TUMo2x7Of0ldhwVZOYJV3qhuc95ryhtbMD1+01Jfmr7WjAjP3WfPV7UxeO4hSROtZQTUu2fDfascD7mdsDTNJnhhqzMZ5TZsPss= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB243; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB243;31:SAeubBbby3IeIptbGea8Ytx8ov3q+BKU6elhKJl2ZsHho0rTyrzt+3hGURiC5DtshKlUPaTXxTGdBN+DZS+GlvD086WA2gMCA6J8xxgk+nz58krv2U7uoDTxpgSKj6mSnBZvHI8RHSthO5v9+nPJZvcsAi1CCNAz0Q1utNPbdPePFg4hEDu/LT/XODQnng8UEF231Rhz72jFxYlDrgYhxQ==;4:VuAf0T9npoqpvodMDE+n4Yey3TGRX26WcNkgy70CknRO4FU0xzt0TMK5tRYqd4wf0Iqc5fxO1eF71uYb7c7MPFeCwAdH0kHHmLqXnOW+nWy8IZTwGoQ2XmzWS1hqKnz0zmH6oV0Sb2bGDDCr91t7EAKKLXnp0hHWb8/859JDR+xrh1wUFE64g0sGWi/Z7wldFK9qbw9Hr1b+/PBvSm2REhTgmYnCMwhGyudwHTqqixJfQjVo7GXwY2q2AX/trmb+dYWusnOOgfyxkaC/Tr9id7S4yOVAbOho/X+5L/6PNyf1ktAiMQE7SsbTA4M0q0W1N3BXkjEgKK1RJ6105f+E3PFrjYPy6HeEPBGte+QZxjRs9aLJ0ujoZqYr7LUdi+dxIOzFqh5rb9qzluGnWWUF+g7tg4bsbjkaEhy1wcCcnKqc7fxdGzGktePJ0cLL2Dx1bzsEzhIAB1WdoI3BynFVmncO/VGylQfUXqIL/gzgInQgAhDyvOKUrIH6eEI4i0Maz0Js7EXTkAzpNHEGcxvuTQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13015025)(13017025)(13024025)(13023025)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BL2PR03MB243;BCL:0;PCL:0;RULEID:(400006);SRVR:BL2PR03MB243; X-Forefront-PRVS: 0993689CD1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB243;23:urbprTSkWwDeAszQcCq5xxwxBlu9BspT92bTTASDbU?= =?us-ascii?Q?p65bFwWJRxl9/hNEDW75OAeZsLXEWMT2ZwD/KUeV9zNLtqjtIhi+1sycuRXU?= =?us-ascii?Q?MOrhWBHFRarXK+Tiogj64c4exp5ZxdVeN5vLhLyeO0gxFXiOJsHv++BkjHf+?= =?us-ascii?Q?oko1EawXgjOtSfDID5WLiQxwmCCsbNW5jUQWyQsgS+fk7YcQzSCaQQFpIAFk?= =?us-ascii?Q?A5jj1jNf0ngIE/P/e9VyKcb3xZQnEhBe5hwpDEWAyZnr02tz3pxnZBpfGv0S?= =?us-ascii?Q?D+b3O20/zqCP8S6gJPFVZZgBIj+jWKo4NVKUDALNvZe/KzmYhfj2XNsm3oeX?= =?us-ascii?Q?GOJbBgccLBh+ZjeDFmd5xcgdtW6TTQeuHCqKDd0YWlmX8pyhukSJ2tz/+10M?= =?us-ascii?Q?+IL6o4Xv/x/yw4Nnnk0HivqMiv+zh9StlSrGLnsjVWmTSLLnTJi2CrzsGlGl?= =?us-ascii?Q?rII3SaTFZAhdzcui/5rs6CuvSU33Gxfnmuk1C1Qvk11sKi0ItMAsyiBMQoHR?= =?us-ascii?Q?9yD5CrEykZqkps9UU9S/IFIZa4B6/MoALTfxzO364NLZOOExnMLPzHJtLQPl?= =?us-ascii?Q?Pcvzo4lX79Tsu+bo2ZsOKvhhmWpB5pv8+dz26SOovGJt8TU6SfVIrFirhAPB?= =?us-ascii?Q?Y0sMhiZispHI9gnaXwawUIUOBCqPMkeHPTA3lAhB0UHXsduySCHYqQIv37Re?= =?us-ascii?Q?fXrLaafbezQGIUlCYd0lnX9fPJwGiytxaKwxnaG0DfELN5VhCdP9K+qnnLxO?= =?us-ascii?Q?HAhrTCAK3OS1H655QOojof7dQU/YMwtLXgrvvin2KN5lZJU49YQI/4/yD17O?= =?us-ascii?Q?Rwzw5betYt5XtZFef5vKm3awBF6x9szxCvZN8+tcdhtw+EzmEjQAph3p9X2A?= =?us-ascii?Q?ehwjka/pJe/M5HjME2WL4vLoUG1VUFmS5sdPJcCLD1kIPFD9t7p6VvCPYrFw?= =?us-ascii?Q?J5IIrsLYcQSVez00TAUWHJm8fb+gxwP5ehWX86Z3KAoqVFhS2aJ+2zM9hNN+?= =?us-ascii?Q?YyYO/OZ1ZNaMJKHDc5zfyGjRAqXDz7j2YpZNSe9XaQDxgn0U3Kp0SYjyHlCT?= =?us-ascii?Q?KfE1g2s6Vh32XSFNnlRm75hTOiALfXzBvMZlmJgvL8zahf/oOmSlnNDidV/Z?= =?us-ascii?Q?jL1GsTTU8=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB243;6:/97JadAZR89DjGw+/thKFDYwkPtO8rImXxYttYdupr9slIQ2g2bWQAcSQLvepDqc4pOKWF7FS3PI+V2uIhSaBk9ZhQmViPkqC8NgvmgkDsICns3DEUEnFohEzxIushfMIrNAhWY2NME0gL7pYqGDbhqCG/hvsWtoWo4pmuKbV0yry7ktgkcdD3SCi3nNoy51I+lW+aXRvkfGAWYxCf+Q2rJTnjXHuxP211tB84DJOyMh+QQy+eADNbwluwLrjdI4K5Xzi+THK6fBZJLX2K/JLxe5ojneHWdP5JvNHabJ7yM=;5:6VAFrWENce9JzFnLDeTKcbyw2RZKwv7HpYCPgrxKAYNVV5aok81RREI/S+PPQ0TSPi4sc/89fittft9wDFkxzPbcc+lXa+wOiNycpqxfD6SuAC5qUYl3l9qGU0Snmai2taLf+I+14QC4g2XWKBRqLdGEhDriCGRbLPkMGqANhpo=;24:TcFXED+tL098TQ9Vos13erMo9H3/iQJc7XgR110831iBWbygPXt+iRJ10pFUt3WuEFa9BHRssm0769Xr9xbqFed98P9z8q9XWwdMBJybk8k=;7:lqwEh2NwzytOCQKk0aJFY9535nla0G1UlS6sUdGqQC7mcwEU0eURjNkG/ykKOnRxJKR5Nbq7JR6fu8F9rCcSNhMSQd+IRhUU/xLKCjT56h6fwip+qybRn1+dPbV82yO/23HSducoRAEsPPgigp6SUMqTIMbhAHdWaMtshrJasUj4EPLZgS3dxGc5VtwJyTw8lL1OBNv9cX7MPBg3q+rduqQokS9fggphRoNKYNoPOnxYD9BKmEhiHnDrd9obbjoJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2016 07:03:07.1402 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB243 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Besides, of_address_to_resource always returns -EINVAL for error, delete the assignment for ret. Signed-off-by: Peter Chen --- drivers/firmware/arm_scpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 7e3e595..fbf10d1 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -683,9 +683,10 @@ static int scpi_probe(struct platform_device *pdev) struct mbox_client *cl = &pchan->cl; struct device_node *shmem = of_parse_phandle(np, "shmem", idx); - if (of_address_to_resource(shmem, 0, &res)) { + ret = of_address_to_resource(shmem, 0, &res); + of_node_put(shmem); + if (ret) { dev_err(dev, "failed to get SCPI payload mem resource\n"); - ret = -EINVAL; goto err; } -- 1.9.1