From: Rik van Riel <riel@redhat.com>
To: Nikolay Borisov <kernel@kyup.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@kernel.org, pbonzini@redhat.com,
fweisbec@redhat.com, wanpeng.li@hotmail.com, efault@gmx.de,
tglx@linutronix.de, rkrcmar@redhat.com
Subject: Re: [PATCH v3 0/4] sched,time: fix irq time accounting with nohz_idle
Date: Tue, 05 Jul 2016 09:09:04 -0400 [thread overview]
Message-ID: <1467724144.17336.42.camel@redhat.com> (raw)
In-Reply-To: <577BAFF1.6080806@kyup.com>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On Tue, 2016-07-05 at 16:02 +0300, Nikolay Borisov wrote:
>
> On 06/30/2016 10:35 PM, riel@redhat.com wrote:
> > Currently irq time accounting only works in these cases:
> > 1) purely ticke based accounting
> > 2) nohz_full accounting, but only on housekeeping & nohz_full CPUs
> > 3) architectures with native vtime accounting
> >
> > On nohz_idle CPUs, which are probably the majority nowadays,
> > irq time accounting is currently broken. This leads to systems
> > reporting a dramatically lower amount of irq & softirq time than
> > is actually spent handling them, with all the time spent while the
> > system is in the idle task being accounted as idle.
>
> Is this supposed to alleviate the issue reported here:
> http://www.gossamer-threads.com/lists/linux/kernel/2169180
Indeed, it is.
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-07-05 13:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 19:35 [PATCH v3 0/4] sched,time: fix irq time accounting with nohz_idle riel
2016-06-30 19:35 ` [PATCH 1/4] sched,time: count actually elapsed irq & softirq time riel
2016-07-05 12:40 ` Frederic Weisbecker
2016-07-05 13:08 ` Rik van Riel
2016-07-05 14:00 ` Frederic Weisbecker
2016-07-05 16:47 ` [PATCH v3 " Rik van Riel
2016-07-06 14:15 ` Frederic Weisbecker
2016-06-30 19:35 ` [PATCH 2/4] nohz,cputime: replace VTIME_GEN irq time code with IRQ_TIME_ACCOUNTING code riel
2016-06-30 19:35 ` [PATCH 3/4] irqtime: add irq type parameter to irqtime_account_irq riel
2016-06-30 19:35 ` [PATCH 4/4] irqtime: drop local_irq_save/restore from irqtime_account_irq riel
2016-07-08 12:30 ` Frederic Weisbecker
2016-07-08 13:19 ` Rik van Riel
2016-07-08 14:01 ` Frederic Weisbecker
2016-07-08 14:34 ` Paolo Bonzini
2016-07-08 15:56 ` Rik van Riel
2016-07-08 23:58 ` Frederic Weisbecker
2016-07-05 13:02 ` [PATCH v3 0/4] sched,time: fix irq time accounting with nohz_idle Nikolay Borisov
2016-07-05 13:09 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467724144.17336.42.camel@redhat.com \
--to=riel@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@redhat.com \
--cc=kernel@kyup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox