From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755748AbcGEWOl (ORCPT ); Tue, 5 Jul 2016 18:14:41 -0400 Received: from smtprelay0035.hostedemail.com ([216.40.44.35]:55398 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751962AbcGEWOj (ORCPT ); Tue, 5 Jul 2016 18:14:39 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6119:7875:7903:10004:10400:10848:11232:11658:11783:11914:12048:12517:12519:12663:12740:13069:13311:13357:13439:13894:14659:21080:21433:30054:30064:30079:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: car16_7f6818754e637 X-Filterd-Recvd-Size: 2617 Message-ID: <1467756874.16342.11.camel@perches.com> Subject: Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings From: Joe Perches To: Markus Mayer , Andrew Morton , Al Viro , Rasmus Villemoes , Chris Metcalf , Kees Cook Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-acpi@vger.kernel.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 05 Jul 2016 15:14:34 -0700 In-Reply-To: <1467751631-22878-1-git-send-email-mmayer@broadcom.com> References: <1467751631-22878-1-git-send-email-mmayer@broadcom.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: > This series introduces a family of generic string case conversion > functions. This kind of functionality is needed in several places in > the kernel. Right now, everybody seems to be implementing their own > copy of this functionality. > > Based on the discussion of the previous version of this series[1] and > the use cases found in the kernel, it does look like having several > flavours of case conversion functions is beneficial. The use cases fall > into three categories: >     - copying a string and converting the case while specifying a >       maximum length to mimic strncpy() >     - copying a string and converting the case without specifying a >       length to mimic strcpy() >     - converting the case of a string in-place (i.e. modifying the >       string that was passed in) > > Consequently, I am proposing these new functions: >     char *strncpytoupper(char *dst, const char *src, size_t len); >     char *strncpytolower(char *dst, const char *src, size_t len); >     char *strcpytoupper(char *dst, const char *src); >     char *strcpytolower(char *dst, const char *src); >     char *strtoupper(char *s); >     char *strtolower(char *s); I think there isn't much value in anything other than strto. Using str[n]cpy followed by strto is pretty obvious and rarely used anyway.