From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbcGHCmr (ORCPT ); Thu, 7 Jul 2016 22:42:47 -0400 Received: from ozlabs.org ([103.22.144.67]:39290 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753487AbcGHCmi convert rfc822-to-8bit (ORCPT ); Thu, 7 Jul 2016 22:42:38 -0400 Message-ID: <1467945755.27479.160.camel@neuling.org> Subject: Re: [PATCH v7 09/11] cpuidle/powernv: cleanup powernv_add_idle_states From: Michael Neuling To: "Shreyas B. Prabhu" , mpe@ellerman.id.au Cc: benh@au1.ibm.com, paulus@ozlabs.org, ego@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, maddy@linux.vnet.ibm.com, "Rafael J. Wysocki" , Daniel Lezcano , linux-pm@vger.kernel.org Date: Fri, 08 Jul 2016 12:42:35 +1000 In-Reply-To: <1467924432-29003-10-git-send-email-shreyas@linux.vnet.ibm.com> References: <1467924432-29003-1-git-send-email-shreyas@linux.vnet.ibm.com> <1467924432-29003-10-git-send-email-shreyas@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >   /* > @@ -230,7 +238,7 @@ static int powernv_add_idle_states(void) >   strcpy(powernv_states[nr_idle_states].desc, "FastSleep"); >   powernv_states[nr_idle_states].flags = CPUIDLE_FLAG_TIMER_STOP; >   powernv_states[nr_idle_states].target_residency = 300000; > - powernv_states[nr_idle_states].enter = &fastsleep_loop; > + powernv_states[nr_idle_states].enter = fastsleep_loop; You can change this code too with the same thing. static struct cpuidle_state powernv_states[CPUIDLE_STATE_MAX] = { { /* Snooze */ .name = "snooze", .desc = "snooze", .exit_latency = 0, .target_residency = 0, .enter = &snooze_loop }, }; Mikey