From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752144AbcGHE1b (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 00:27:31 -0400
Received: from ozlabs.org ([103.22.144.67]:54005 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751110AbcGHE1Y convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 00:27:24 -0400
Message-ID: <1467952040.13193.0.camel@neuling.org>
Subject: Re: [PATCH v7 07/11] powerpc/powernv: Add platform support for stop
 instruction
From: Michael Neuling <mikey@neuling.org>
To: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>, mpe@ellerman.id.au
Cc: benh@au1.ibm.com, paulus@ozlabs.org, ego@linux.vnet.ibm.com,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        maddy@linux.vnet.ibm.com
Date: Fri, 08 Jul 2016 14:27:20 +1000
In-Reply-To: <577F29EF.9090405@linux.vnet.ibm.com>
References: <1467924432-29003-1-git-send-email-shreyas@linux.vnet.ibm.com>
	 <1467924432-29003-8-git-send-email-shreyas@linux.vnet.ibm.com>
	 <1467944442.27479.155.camel@neuling.org>
	 <577F29EF.9090405@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > > 
> > > @@ -439,7 +540,18 @@ timebase_resync:
> > >  	 */
> > >  	bne	cr4,clear_lock
> > >  
> > > -	/* Restore per core state */
> > > +	/*
> > > +	 * First thread in the core to wake up and its waking up
> > > with
> > > +	 * complete hypervisor state loss. Restore per core
> > > hypervisor
> > > +	 * state.
> > > +	 */
> > > +BEGIN_FTR_SECTION
> > > +	ld	r4,_PTCR(r1)
> > > +	mtspr	SPRN_PTCR,r4
> > > +	ld	r4,_RPR(r1)
> > > +	mtspr	SPRN_RPR,r4
> > RPR looks wrong here.  This should be on POWER8 too.
> > 
> > This has changed since v6 and not noted in the v7 comments.  Why are
> > you
> > changing this now?
> > 
> RPR is a per-core resource in P9. So with this patch, RPR will continue
> to be restored per-subcore in P8 and will restored once per core in P9.

Ok, thanks for the explanation.

Mikey