Re: [PATCH] nfsd: Make creates return EEXIST correctly instead of EPERM

J. Bruce Fields
2016-07-22T17:49:08Z

From: "J. Bruce Fields" <bfields@redhat.com>

On Fri, Jul 22, 2016 at 11:13:20AM -0400, Oleg Drokin wrote:
> Hm, in fact indeed. I was just too worked up about the client side,
> but on the server side there was a real lookup already, so it does
> look workable.

So I end up with the following. This is all (after your patch) pretty
trivial cleanup, but I think it's overdue for that code.

--b.

J. Bruce Fields (6):
nfsd: remove redundant zero-length check from create
nfsd: remove redundant i_lookup check
nfsd: reorganize nfsd_create
nfsd: remove unnecessary positive-dentry check
nfsd: clean up bad-type check in nfsd_create_locked
nfsd: drop unnecessary MAY_EXEC check from create

Oleg Drokin (1):
nfsd: Make creates return EEXIST instead of EACCES

fs/nfsd/nfs4proc.c | 3 +-
fs/nfsd/nfsproc.c | 7 +--
fs/nfsd/vfs.c | 131 ++++++++++++++++++++++++-----------------------------
fs/nfsd/vfs.h | 3 ++
4 files changed, 66 insertions(+), 78 deletions(-)

--
2.7.4