From: Tim Chen <tim.c.chen@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Megha Dey <megha.dey@intel.com>,
"Wang, Rui Y" <rui.y.wang@intel.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Xiaodong Liu <xiaodong.liu@intel.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] crypto: sha256-mb - cleanup a || vs | typo
Date: Fri, 08 Jul 2016 10:17:32 -0700 [thread overview]
Message-ID: <1467998252.9191.8.camel@linux.intel.com> (raw)
In-Reply-To: <20160708164502.GA3064@gondor.apana.org.au>
On Sat, 2016-07-09 at 00:45 +0800, Herbert Xu wrote:
> On Fri, Jul 08, 2016 at 09:28:03AM -0700, Tim Chen wrote:
> >
> >
> > Sorry I was on vacation and didn't get to respond earlier.
> > Let's switch the above from | to || so the code logic is
> > clearer. Also clean up various multi-line comment style
> > inconsistencies in patch below.
> Nack. As I said the commenting style in the crypto API is the
> same as the network stack. So unless we decide to change both
> please stick to the current style.
>
Will you like a patch with just the | to || change, or leave
the code as is?
Tim
next prev parent reply other threads:[~2016-07-08 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:42 [patch] crypto: sha256-mb - cleanup a || vs | typo Dan Carpenter
2016-06-29 17:05 ` H. Peter Anvin
2016-06-30 7:50 ` Dan Carpenter
2016-06-30 11:16 ` Joe Perches
2016-06-30 11:45 ` walter harms
2016-06-30 12:33 ` Dan Carpenter
2016-06-30 20:42 ` Tim Chen
2016-06-30 22:16 ` Dan Carpenter
2016-07-01 7:55 ` Ingo Molnar
2016-07-01 9:28 ` Herbert Xu
2016-07-01 10:13 ` Ingo Molnar
2016-07-08 16:28 ` Tim Chen
2016-07-08 16:45 ` Herbert Xu
2016-07-08 17:17 ` Tim Chen [this message]
2016-07-08 17:19 ` Linus Torvalds
2016-07-11 6:40 ` Geert Uytterhoeven
2016-07-18 8:59 ` Pavel Machek
2016-07-18 22:12 ` Tim Chen
2016-07-11 10:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467998252.9191.8.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rui.y.wang@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xiaodong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).