From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932704AbcGHRSH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 13:18:07 -0400
Received: from mga11.intel.com ([192.55.52.93]:21195 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932302AbcGHRR5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 13:17:57 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,331,1464678000"; 
   d="scan'208";a="842883504"
Message-ID: <1467998252.9191.8.camel@linux.intel.com>
Subject: Re: [patch] crypto: sha256-mb - cleanup a || vs | typo
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        x86@kernel.org, Megha Dey <megha.dey@intel.com>,
        "Wang, Rui Y" <rui.y.wang@intel.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Xiaodong Liu <xiaodong.liu@intel.com>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Fri, 08 Jul 2016 10:17:32 -0700
In-Reply-To: <20160708164502.GA3064@gondor.apana.org.au>
References: <20160629144242.GE22818@mwanda>
	 <8538242a-eab7-127e-e47e-26027fee4f6d@zytor.com>
	 <1467319339.22178.256.camel@linux.intel.com>
	 <20160701075559.GA11902@gmail.com>
	 <20160701092806.GA13424@gondor.apana.org.au>
	 <20160701101329.GA3833@gmail.com> <20160708162803.GA29111@linux.intel.com>
	 <20160708164502.GA3064@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2016-07-09 at 00:45 +0800, Herbert Xu wrote:
> On Fri, Jul 08, 2016 at 09:28:03AM -0700, Tim Chen wrote:
> > 
> > 
> > Sorry I was on vacation and didn't get to respond earlier.
> > Let's switch the above from | to || so the code logic is
> > clearer.  Also clean up various multi-line comment style
> > inconsistencies in patch below.
> Nack.  As I said the commenting style in the crypto API is the
> same as the network stack.  So unless we decide to change both
> please stick to the current style.
> 

Will you like a patch with just the | to || change, or leave
the code as is?

Tim