From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754415AbcGLOTZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 10:19:25 -0400
Received: from mga14.intel.com ([192.55.52.115]:65064 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754357AbcGLOTY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 10:19:24 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,352,1464678000"; 
   d="scan'208";a="1005323528"
Message-ID: <1468333123.6604.2.camel@linux.intel.com>
Subject: Re: [PATCH -next] nvme-rdma: fix the return value of
 nvme_rdma_reinit_request()
From: J Freyensee <james_p_freyensee@linux.intel.com>
To: weiyj_lk@163.com, Keith Busch <keith.busch@intel.com>,
        Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org
Date: Tue, 12 Jul 2016 07:18:43 -0700
In-Reply-To: <1468321577-16278-1-git-send-email-weiyj_lk@163.com>
References: <1468321577-16278-1-git-send-email-weiyj_lk@163.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-07-12 at 11:06 +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> PTR_ERR should be applied before its argument is reassigned,
> otherwise the
> return value will be set to 0, not error code.

Another good catch.

Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com>

> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

>  	if (IS_ERR(req->mr)) {
> -		req->mr = NULL;
>  		ret = PTR_ERR(req->mr);
> +		req->mr = NULL;
>  	}