From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753868AbcGLQPq (ORCPT ); Tue, 12 Jul 2016 12:15:46 -0400 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:47478 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751611AbcGLQPo (ORCPT ); Tue, 12 Jul 2016 12:15:44 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2892:3138:3139:3140:3141:3142:3355:3618:3622:3865:3867:3868:3870:3871:3872:3873:4321:5007:6120:8603:10004:10400:10848:11026:11232:11473:11657:11658:11783:11914:12043:12048:12296:12517:12519:12663:12740:13095:13439:13894:14096:14097:14659:14721:21080:21212:21324:21433:30045:30054:30070:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hour69_143edd7cd2f36 X-Filterd-Recvd-Size: 3324 Message-ID: <1468340137.8745.20.camel@perches.com> Subject: Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors From: Joe Perches To: Shuah Khan , kyungmin.park@samsung.com, k.debski@samsung.com, jtp.park@samsung.com, mchehab@kernel.org, javier@osg.samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 Jul 2016 09:15:37 -0700 In-Reply-To: <57851607.9050005@osg.samsung.com> References: <1468276740-1591-1-git-send-email-shuahkh@osg.samsung.com> <1468332418.8745.11.camel@perches.com> <578501E9.6090008@osg.samsung.com> <1468338700.8745.14.camel@perches.com> <57851607.9050005@osg.samsung.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-07-12 at 10:08 -0600, Shuah Khan wrote: > On 07/12/2016 09:51 AM, Joe Perches wrote: > > On Tue, 2016-07-12 at 08:42 -0600, Shuah Khan wrote: > > > On 07/12/2016 08:06 AM, Joe Perches wrote: > > > > On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote: > > > > > > > > > > Fix misspelled error message and existing checkpatch errors in the > > > > > error message conditional. > > > > [] > > > > > > > > > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > > > > [] > > > > > > > > > > @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv, > > > > >   u32 left, right, top, bottom; > > > > >   > > > > >   if (ctx->state != MFCINST_HEAD_PARSED && > > > > > - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING > > > > > - && ctx->state != MFCINST_FINISHED) { > > > > > - mfc_err("Cannont set crop\n"); > > > > > - return -EINVAL; > > > > > - } > > > > > +     ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING > > > > > +     && ctx->state != MFCINST_FINISHED) { > > > > > + mfc_err("Can not get crop information\n"); > > > > > + return -EINVAL; > > > > > + } > > > > is it a set or a get? > > > vidioc_g_crop is a get routine. > > > > > > > > > > > > It'd be nicer for humans to read if the alignment was consistent > > > Are you okay with this alignment change or would you like it > > > changed? > > Well, if you're resubmitting, I'd prefer it changed. > > Thanks. > > > chekcpatch stopped complaining. Are you looking for the entire file > alignments changed? I am not clear on what needs to be changed? I think doing just this spelling and get/set correction and fixing the alignment in this single case in a single patch would be fine here. Foxing the alignment for the entire file would be a more significant change and isn't necessary in this patch. Another thing possible for the file would be to change the mfc_debug and mfc_err/mfc_info macros to use pr_ without the generally unnecessary __func__ and __LINE__ uses. This could both enable dynamic_debug uses for the KERN_DEBUG cases and reduce overall object size.