From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbcGMH4a (ORCPT ); Wed, 13 Jul 2016 03:56:30 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:23148 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751082AbcGMH4V (ORCPT ); Wed, 13 Jul 2016 03:56:21 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="8660340" From: "Wei, Jiangang" To: "boris.ostrovsky@oracle.com" CC: "linux-kernel@vger.kernel.org" , "david.vrabel@citrix.com" , "tglx@linutronix.de" , "jgross@suse.com" , "konrad.wilk@oracle.com" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "xen-devel@lists.xenproject.org" Subject: Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask Thread-Topic: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask Thread-Index: AQHR1//7949dlQIDyEKIVc6kFi4ZmaAMkWSAgAADk4CACOxLgA== Date: Wed, 13 Jul 2016 07:56:10 +0000 Message-ID: <1468396427.2020.14.camel@localhost> References: <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com> <20160707152510.GJ17766@localhost.localdomain> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.167.226.50] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-yoursite-MailScanner-ID: 6758D41C0B8A.ADAFF X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: weijg.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u6D7uiOT001401 On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote: > On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: > >> verify_local_APIC() had been removed by > >> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), > >> so apic_id_mask isn't used by it. > > Is anyone actually using this field? It looks like 4399c03c6780 removed > the only user. Indeed, the field is useless. Maybe we can remove this field from the struct apic . what's your opinion? Thanks, wei > > -boris > > > > CC-ing the proper maintainers. > >> Signed-off-by: Wei Jiangang > >> --- > >> arch/x86/xen/apic.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c > >> index db52a7fafcc2..9cbb1f48381b 100644 > >> --- a/arch/x86/xen/apic.c > >> +++ b/arch/x86/xen/apic.c > >> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = { > >> > >> .get_apic_id = xen_get_apic_id, > >> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */ > >> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */ > >> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */ > >> > >> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and, > >> > >> -- > >> 1.9.3 > >> > >> > >> > >> > >> _______________________________________________ > >> Xen-devel mailing list > >> Xen-devel@lists.xen.org > >> https://lists.xen.org/xen-devel > > > >