From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbcGNRrP (ORCPT ); Thu, 14 Jul 2016 13:47:15 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:44302 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751051AbcGNRrM (ORCPT ); Thu, 14 Jul 2016 13:47:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:4321:4385:5007:8957:10004:10400:10848:11026:11232:11473:11658:11783:11914:12048:12296:12517:12519:12740:13069:13255:13311:13357:13439:13523:13524:13894:14659:14721:21080:30029:30054:30080:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: rat76_3e755316cbc26 X-Filterd-Recvd-Size: 2199 Message-ID: <1468518428.8745.43.camel@perches.com> Subject: Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver From: Joe Perches To: Tai Nguyen , mark.rutland@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, paul.gortmaker@windriver.com Cc: dhdang@apm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@apm.com Date: Thu, 14 Jul 2016 10:47:08 -0700 In-Reply-To: <1468517266-1642-4-git-send-email-ttnguyen@apm.com> References: <1468517266-1642-1-git-send-email-ttnguyen@apm.com> <1468517266-1642-4-git-send-email-ttnguyen@apm.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote: > This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware > found in APM X-Gene SoCs. trivia: > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c [] > +struct xgene_pmu_dev_ctx { > + char *name; > + struct list_head next; > + struct xgene_pmu_dev *pmu_dev; > + struct hw_pmu_info inf; > +}; Probably better to use something like char name[20]; as the kasprintf can fail and this doesn't seem to be freed anywhere. > +static char *xgene_pmu_dev_name(u32 type, int id) > +{ > + switch (type) { > + case PMU_TYPE_L3C: > + return kasprintf(GFP_KERNEL, "l3c%d", id); > + case PMU_TYPE_IOB: > + return kasprintf(GFP_KERNEL, "iob%d", id); > + case PMU_TYPE_MCB: > + return kasprintf(GFP_KERNEL, "mcb%d", id); > + case PMU_TYPE_MC: > + return kasprintf(GFP_KERNEL, "mc%d", id); > + default: > + return kasprintf(GFP_KERNEL, "unknown"); > + } > +} [] > +static struct > +xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct xgene_pmu *xgene_pmu, > +        struct acpi_device *adev, u32 type) > +{ [] > + ctx->name = xgene_pmu_dev_name(type, enable_bit); >