From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbcGOE7T (ORCPT ); Fri, 15 Jul 2016 00:59:19 -0400 Received: from smtprelay0196.hostedemail.com ([216.40.44.196]:48509 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750870AbcGOE7Q (ORCPT ); Fri, 15 Jul 2016 00:59:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3872:3873:4321:5007:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12296:12438:12517:12519:12555:12663:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:21434:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: pet39_6da5f194c1c4f X-Filterd-Recvd-Size: 2256 Message-ID: <1468558752.8745.52.camel@perches.com> Subject: Re: [PATCH] powernv: Use __printf in pe_level_printk From: Joe Perches To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 14 Jul 2016 21:59:12 -0700 In-Reply-To: <87eg6vbjr2.fsf@@concordia.ellerman.id.au> References: <87eg6vbjr2.fsf@@concordia.ellerman.id.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-07-15 at 14:36 +1000, Michael Ellerman wrote: > Joe Perches writes: > > > > > Make the compiler detect format and argument mismatches. > > > > Signed-off-by: Joe Perches > > --- > >  arch/powerpc/platforms/powernv/pci.h | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/arch/powerpc/platforms/powernv/pci.h > > b/arch/powerpc/platforms/powernv/pci.h > > index 3a97990..1c1a586 100644 > > --- a/arch/powerpc/platforms/powernv/pci.h > > +++ b/arch/powerpc/platforms/powernv/pci.h > > @@ -213,6 +213,7 @@ extern void pnv_pci_dma_bus_setup(struct pci_bus > > *bus); > >  extern int pnv_setup_msi_irqs(struct pci_dev *pdev, int nvec, int > > type); > >  extern void pnv_teardown_msi_irqs(struct pci_dev *pdev); > >   > > +__printf(3, 4) > >  extern void pe_level_printk(const struct pnv_ioda_pe *pe, const > > char *level, > >       const char *fmt, ...); > Thanks, but it breaks the build due to lots of new warnings. > > We'll have to fix those before merging it. Good.  Are you going to fix those? I thought I did a powerpc defconfig build of arch/powerpc/ and I believe it finished without error, but I'm pleased it found some defects. I think it's now marked "rejected" in patchwork. Perhaps it'd better to mark it "deferred" instead.