From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932305AbcGOHaY (ORCPT ); Fri, 15 Jul 2016 03:30:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932248AbcGOHaT (ORCPT ); Fri, 15 Jul 2016 03:30:19 -0400 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Songshan Gong , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: [PATCH 3/3] tools lib api fs: Use base 0 in filename__read_ull Date: Fri, 15 Jul 2016 09:29:57 +0200 Message-Id: <1468567797-27564-4-git-send-email-jolsa@kernel.org> In-Reply-To: <1468567797-27564-1-git-send-email-jolsa@kernel.org> References: <1468567797-27564-1-git-send-email-jolsa@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 15 Jul 2016 07:30:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By using 0 for base, the strtoull detects the base automatically (see man strtoull). ATM we have just one user of this function, the cpu__get_max_freq function reading cpuinfo_max_freq sysfs. It should not get affected by this change. Cc: Songshan Gong Link: http://lkml.kernel.org/n/tip-f56zxnejrzt9gfernqb034z8@git.kernel.org Signed-off-by: Jiri Olsa --- tools/lib/api/fs/fs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index 08556cf2c70d..ba7094b945ff 100644 --- a/tools/lib/api/fs/fs.c +++ b/tools/lib/api/fs/fs.c @@ -283,6 +283,11 @@ int filename__read_int(const char *filename, int *value) return err; } +/* + * Parses @value out of @filename with strtoull. + * By using 0 for base, the strtoull detects the + * base automatically (see man strtoull). + */ int filename__read_ull(const char *filename, unsigned long long *value) { char line[64]; @@ -292,7 +297,7 @@ int filename__read_ull(const char *filename, unsigned long long *value) return -1; if (read(fd, line, sizeof(line)) > 0) { - *value = strtoull(line, NULL, 10); + *value = strtoull(line, NULL, 0); if (*value != ULLONG_MAX) err = 0; } -- 2.4.11