* [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle
@ 2016-07-15 9:38 Peter Chen
2016-07-15 18:50 ` Bjorn Andersson
2016-08-08 13:39 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Peter Chen @ 2016-07-15 9:38 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Peter Chen, Bjorn Andersson
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/mfd/qcom_rpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 2e44323..ecca115 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
}
rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
+ of_node_put(syscon_np);
if (IS_ERR(rpm->ipc_regmap))
return PTR_ERR(rpm->ipc_regmap);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle
2016-07-15 9:38 [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle Peter Chen
@ 2016-07-15 18:50 ` Bjorn Andersson
2016-08-08 13:39 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2016-07-15 18:50 UTC (permalink / raw)
To: Peter Chen; +Cc: lee.jones, linux-kernel, Bjorn Andersson
On Fri 15 Jul 02:38 PDT 2016, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/mfd/qcom_rpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 2e44323..ecca115 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> }
>
> rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
> + of_node_put(syscon_np);
> if (IS_ERR(rpm->ipc_regmap))
> return PTR_ERR(rpm->ipc_regmap);
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle
2016-07-15 9:38 [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-15 18:50 ` Bjorn Andersson
@ 2016-08-08 13:39 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2016-08-08 13:39 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-kernel, Bjorn Andersson
On Fri, 15 Jul 2016, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/mfd/qcom_rpm.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 2e44323..ecca115 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> }
>
> rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
> + of_node_put(syscon_np);
> if (IS_ERR(rpm->ipc_regmap))
> return PTR_ERR(rpm->ipc_regmap);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-08 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-15 9:38 [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-15 18:50 ` Bjorn Andersson
2016-08-08 13:39 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).